[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnushogi-devel] Informing (proposed) package in Fedora

From: Yann Dirson
Subject: Re: [Gnushogi-devel] Informing (proposed) package in Fedora
Date: Mon, 14 Jul 2014 14:15:40 +0200
User-agent: Mutt/1.5.23 (2014-03-12)


On Mon, Jul 14, 2014 at 05:27:29PM +0800, Chen Chen wrote:
> I'm trying to package the gnushogi (current git snapshot) onto Fedora.

Great news!

> The package is currently under review:
> I selected the git version instead of stable release 1.4.2 because:
> 1. The generated autotool files in 1.4.2 are outdated. It doesn't honor
> "make install DESTDIR=/foo/bar" command, thus render it useless against
> rpmbuild;

Well, you can still run "make install prefix=/whatever/usr", although it
is not as modern :)

> 2. The git version has fairly good support on xboard, which is more
> preferable than deprecated xshogi.

Now *that* is a good reason ;)

> The submitted source is 100% same as git master branch, with additional
> "autoreconf -i" generated files

Beware, you have an autom4te.cache that went into the source tarball.
To get a more official source tarball, I advise you just use "make dist".

> and some minor tweaks in
> * added AM_PROG_CC_C_O: to avoid
> gnushogi/ warning: compiling 'main.c' with per-target
> flags requires 'AM_PROG_CC_C_O' in ''
> * added a AC_CHECK_PROG(/*foobar*/): to avoid
> /home/lunarshaddow/gnushogi/missing: line 81: makeinfo: command not
> found

Sounds good, but you should really include such changes as patches in
your source package.

You can also publish them as git commits in a repo of you own (maybe
on github as a fork of, since I
don't think anyone can do that on savannah)

Note that in the src.rpm linked from the above ticket, I can only see
the AM_PROG_CC_C_O change and not the second one.

I am also puzzled by the need for AM_PROG_CC_C_O: I don't have such a
warning here - but then, I'm using automake 1.14.1 and you're
apparently using 1.13.4, so that may be the reason.
I should really see how we could testbuild on various OS versions to
catch such issues as early as possible.

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]