[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[libeufin] branch master updated: Fixing comments.
From: |
gnunet |
Subject: |
[libeufin] branch master updated: Fixing comments. |
Date: |
Mon, 25 Sep 2023 14:10:31 +0200 |
This is an automated email from the git hooks/post-receive script.
ms pushed a commit to branch master
in repository libeufin.
The following commit(s) were added to refs/heads/master by this push:
new 63e7e02c Fixing comments.
63e7e02c is described below
commit 63e7e02ca0e7b31ac90fa247dd2df79d9a493c03
Author: MS <ms@taler.net>
AuthorDate: Mon Sep 25 14:06:49 2023 +0200
Fixing comments.
Removing accidental "//" from single-line comments
and placing a FIXME above the spaCaptchaURL field.
---
bank/src/main/kotlin/tech/libeufin/bank/CorebankApiHandlers.kt | 6 +++---
bank/src/main/kotlin/tech/libeufin/bank/Main.kt | 2 +-
contrib/wallet-core | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/bank/src/main/kotlin/tech/libeufin/bank/CorebankApiHandlers.kt
b/bank/src/main/kotlin/tech/libeufin/bank/CorebankApiHandlers.kt
index b1717e0d..75316979 100644
--- a/bank/src/main/kotlin/tech/libeufin/bank/CorebankApiHandlers.kt
+++ b/bank/src/main/kotlin/tech/libeufin/bank/CorebankApiHandlers.kt
@@ -145,7 +145,7 @@ fun Routing.accountsMgmtHandlers(db: Database, ctx:
BankApplicationContext) {
passwordHash = CryptoUtil.hashpw(req.password),
)
val newCustomerRowId = db.customerCreate(newCustomer)
- ?: throw internalServerError("New customer INSERT failed despite
the previous checks") // Crashing here won't break data consistency between
customers // and bank accounts, because of the idempotency. Client will //
just have to retry.
+ ?: throw internalServerError("New customer INSERT failed despite
the previous checks") // Crashing here won't break data consistency between
customers and bank accounts, because of the idempotency. Client will just have
to retry.
val maxDebt = ctx.defaultCustomerDebtLimit
val newBankAccount = BankAccount(
hasDebt = false,
@@ -192,7 +192,7 @@ fun Routing.accountsMgmtHandlers(db: Database, ctx:
BankApplicationContext) {
val c = call.authenticateBankRequest(db, TokenScope.readonly) ?: throw
unauthorized("Login failed")
val resourceName = call.maybeUriComponent("USERNAME") ?: throw
badRequest(
hint = "No username found in the URI", talerErrorCode =
TalerErrorCode.TALER_EC_GENERIC_PARAMETER_MISSING
- ) // Checking resource name only if Basic auth was used. // Successful
tokens do not need this check, they just pass.
+ ) // Checking resource name only if Basic auth was used. Successful
tokens do not need this check, they just pass.
if (((c.login != resourceName) && (c.login != "admin")) &&
(call.getAuthToken() == null)) throw forbidden("No rights on the resource.")
val customerData = db.customerGetFromLogin(c.login)
?: throw internalServerError("Customer '${c.login} despite being
authenticated.'")
@@ -370,7 +370,7 @@ fun Routing.accountsMgmtHandlers(db: Database, ctx:
BankApplicationContext) {
val paytoWithoutParams = stripIbanPayto(txData.payto_uri)
val subject = payto.message ?: throw badRequest("Wire transfer lacks
subject")
val debtorId = c.dbRowId
- ?: throw internalServerError("Debtor database ID not found") //
This performs already a SELECT on the bank account, // like the wire transfer
will do as well later!
+ ?: throw internalServerError("Debtor database ID not found") //
This performs already a SELECT on the bank account, like the wire transfer will
do as well later!
logger.info("creditor payto: $paytoWithoutParams")
val creditorCustomerData =
db.bankAccountGetFromInternalPayto(paytoWithoutParams) ?: throw notFound(
"Creditor account not found", TalerErrorCode.TALER_EC_END //
FIXME: define this EC.
diff --git a/bank/src/main/kotlin/tech/libeufin/bank/Main.kt
b/bank/src/main/kotlin/tech/libeufin/bank/Main.kt
index 67cf4c4d..33f3dc7e 100644
--- a/bank/src/main/kotlin/tech/libeufin/bank/Main.kt
+++ b/bank/src/main/kotlin/tech/libeufin/bank/Main.kt
@@ -105,7 +105,7 @@ data class BankApplicationContext(
*/
val maxAuthTokenDurationUs: Long,
/**
- * Max token duration in microseconds.
+ * FIXME/TBD.
*/
val spaCaptchaURL: String?,
)
diff --git a/contrib/wallet-core b/contrib/wallet-core
index 9e2d95b3..c5a3cd4c 160000
--- a/contrib/wallet-core
+++ b/contrib/wallet-core
@@ -1 +1 @@
-Subproject commit 9e2d95b39723a038eb714d723ac0910a5bf596e2
+Subproject commit c5a3cd4c50676c49fa6c67cbdeb609101c38e764
--
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [libeufin] branch master updated: Fixing comments.,
gnunet <=