gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[taler-merchant] branch master updated: -remove FIXMEs that have been re


From: gnunet
Subject: [taler-merchant] branch master updated: -remove FIXMEs that have been resolved
Date: Mon, 11 Jul 2022 18:26:10 +0200

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository merchant.

The following commit(s) were added to refs/heads/master by this push:
     new 72359733 -remove FIXMEs that have been resolved
72359733 is described below

commit 7235973381c07f76abe66b2d49cedf545e0f92ff
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Mon Jul 11 18:26:07 2022 +0200

    -remove FIXMEs that have been resolved
---
 src/testing/test_kyc_api.c                 | 7 -------
 src/testing/testing_api_cmd_get_instance.c | 3 +--
 src/testing/testing_api_cmd_get_reserves.c | 3 +--
 3 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/src/testing/test_kyc_api.c b/src/testing/test_kyc_api.c
index 490aa6e4..f10803d1 100644
--- a/src/testing/test_kyc_api.c
+++ b/src/testing/test_kyc_api.c
@@ -222,13 +222,6 @@ run (void *cls,
     CMD_EXEC_AGGREGATOR ("run-aggregator"),
     /* KYC: hence nothing happened at the bank yet: */
     TALER_TESTING_cmd_check_bank_empty ("check_bank_empty-2"),
-    /* FIXME-#7052: this should ideally not be needed... */
-    TALER_TESTING_cmd_merchant_get_order ("get-order",
-                                          merchant_url,
-                                          "create-proposal-1",
-                                          TALER_MERCHANT_OSC_PAID,
-                                          false,
-                                          MHD_HTTP_OK),
     TALER_TESTING_cmd_merchant_kyc_get ("kyc-pending",
                                         merchant_url,
                                         NULL,
diff --git a/src/testing/testing_api_cmd_get_instance.c 
b/src/testing/testing_api_cmd_get_instance.c
index f328cc75..95dc7282 100644
--- a/src/testing/testing_api_cmd_get_instance.c
+++ b/src/testing/testing_api_cmd_get_instance.c
@@ -108,7 +108,6 @@ get_instance_cb (void *cls,
                  const struct TALER_MERCHANT_Account accounts[],
                  const struct TALER_MERCHANT_InstanceDetails *details)
 {
-  /* FIXME, deeper checks should be implemented here (for accounts). */
   struct GetInstanceState *gis = cls;
   const struct TALER_TESTING_Command *instance_cmd;
 
@@ -289,7 +288,7 @@ get_instance_cb (void *cls,
               0,
               sizeof (unsigned int) * accounts_length);
 
-      // Compare the accounts
+      /* Compare the accounts */
       for (unsigned int i = 0; i < accounts_length; ++i)
       {
         for (unsigned int j = 0; j < gis->active_accounts_length; ++j)
diff --git a/src/testing/testing_api_cmd_get_reserves.c 
b/src/testing/testing_api_cmd_get_reserves.c
index d56b9ce5..ea860c27 100644
--- a/src/testing/testing_api_cmd_get_reserves.c
+++ b/src/testing/testing_api_cmd_get_reserves.c
@@ -72,7 +72,6 @@ get_reserves_cb (void *cls,
                  unsigned int reserves_length,
                  const struct TALER_MERCHANT_ReserveSummary reserves[])
 {
-  /* FIXME, deeper checks should be implemented here. */
   struct GetReservesState *grs = cls;
   bool matched[reserves_length];
   bool fail = false;
@@ -98,7 +97,7 @@ get_reserves_cb (void *cls,
       TALER_TESTING_interpreter_fail (grs->is);
       return;
     }
-    // FIXME: check if the data returned matches that from the POST / PATCH
+    /* check if the data returned matches that from the POST / PATCH */
     memset (matched, 0, sizeof (matched));
     for (unsigned int i = 0; i < reserves_length; ++i)
       for (unsigned int j = 0; j < reserves_length; ++j)

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]