[taler-exchange] branch master updated: -note fixme

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository exchange.

The following commit(s) were added to refs/heads/master by this push:
     new 1628f025 -note fixme
1628f025 is described below

commit 1628f0255c78864fa0af05d065ff31449aa92806
Author: Christian Grothoff <grothoff@gnunet.org>
AuthorDate: Fri Jul 8 15:34:09 2022 +0200

    -note fixme
---
 doc/prebuilt                                | 2 +-
 src/exchangedb/plugin_exchangedb_postgres.c | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/doc/prebuilt b/doc/prebuilt
index b988d98d..1ed97b23 160000
--- a/doc/prebuilt
+++ b/doc/prebuilt
@@ -1 +1 @@
-Subproject commit b988d98d4856758484eb23c27bfdc9e602d4235a
+Subproject commit 1ed97b23f19c80fa84b21a5eb0c686d5491e8ec6
diff --git a/src/exchangedb/plugin_exchangedb_postgres.c 
b/src/exchangedb/plugin_exchangedb_postgres.c
index aa8834c4..dda1ebac 100644
--- a/src/exchangedb/plugin_exchangedb_postgres.c
+++ b/src/exchangedb/plugin_exchangedb_postgres.c
@@ -1779,6 +1779,9 @@ prepare_statements (struct PostgresClosure *pg)
       "   WHERE coin_pub IN (SELECT coin_pub FROM dep)"
       "     AND deposit_serial_id IN (SELECT deposit_serial_id FROM dep))"
       " ,fees AS (" /* find deposit fees for non-refunded deposits */
+      // FIXME: this is wrong, the deposit fee is waived IF the
+      // refunds were for 100% of the deposit value. This logic
+      // ignores this detail :-(.
       "  SELECT"
       "    denom.fee_deposit_val AS fee_val"
       "   ,denom.fee_deposit_frac AS fee_frac"
@@ -7502,7 +7505,7 @@ postgres_aggregate (
                                                  rs);
   if (qs < 0)
   {
-    GNUNET_assert (GNUNET_DB_STATUS_SOFT_ERROR == qs);
+    GNUNET_break (GNUNET_DB_STATUS_SOFT_ERROR == qs);
     return qs;
   }
   if (GNUNET_DB_STATUS_SUCCESS_NO_RESULTS == qs)

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.