[taler-exchange] branch master updated: -remove dead argument

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository exchange.

The following commit(s) were added to refs/heads/master by this push:
     new 9e5dc2a5 -remove dead argument
9e5dc2a5 is described below

commit 9e5dc2a5423992023123a3f2afe1c41343145422
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Tue Jul 5 11:50:20 2022 +0200

    -remove dead argument
---
 src/auditor/taler-helper-auditor-aggregation.c |  1 -
 src/auditor/taler-helper-auditor-coins.c       |  1 -
 src/exchange/taler-exchange-httpd_responses.c  |  2 --
 src/exchangedb/plugin_exchangedb_postgres.c    | 21 +--------------------
 src/exchangedb/test_exchangedb.c               |  2 --
 src/include/taler_exchangedb_plugin.h          |  2 --
 6 files changed, 1 insertion(+), 28 deletions(-)

diff --git a/src/auditor/taler-helper-auditor-aggregation.c 
b/src/auditor/taler-helper-auditor-aggregation.c
index 1c22a48b..190b7d30 100644
--- a/src/auditor/taler-helper-auditor-aggregation.c
+++ b/src/auditor/taler-helper-auditor-aggregation.c
@@ -713,7 +713,6 @@ wire_transfer_information_cb (
   /* Obtain coin's transaction history */
   qs = TALER_ARL_edb->get_coin_transactions (TALER_ARL_edb->cls,
                                              coin_pub,
-                                             GNUNET_YES,
                                              &tl);
   if ( (qs < 0) ||
        (NULL == tl) )
diff --git a/src/auditor/taler-helper-auditor-coins.c 
b/src/auditor/taler-helper-auditor-coins.c
index e7fc81aa..61cd8468 100644
--- a/src/auditor/taler-helper-auditor-coins.c
+++ b/src/auditor/taler-helper-auditor-coins.c
@@ -473,7 +473,6 @@ check_coin_history (const struct TALER_CoinSpendPublicKeyP 
*coin_pub,
 
   qs = TALER_ARL_edb->get_coin_transactions (TALER_ARL_edb->cls,
                                              coin_pub,
-                                             true,
                                              &tl);
   if (0 >= qs)
     return qs;
diff --git a/src/exchange/taler-exchange-httpd_responses.c 
b/src/exchange/taler-exchange-httpd_responses.c
index 92c585b4..c33cdfc1 100644
--- a/src/exchange/taler-exchange-httpd_responses.c
+++ b/src/exchange/taler-exchange-httpd_responses.c
@@ -579,10 +579,8 @@ TEH_RESPONSE_reply_coin_insufficient_funds (
       TALER_EC_GENERIC_DB_START_FAILED,
       NULL);
   }
-  // FIXME: simplify, 3rd arg is always 'true' now?
   qs = TEH_plugin->get_coin_transactions (TEH_plugin->cls,
                                           coin_pub,
-                                          true,
                                           &tl);
   TEH_plugin->rollback (TEH_plugin->cls);
   if (0 > qs)
diff --git a/src/exchangedb/plugin_exchangedb_postgres.c 
b/src/exchangedb/plugin_exchangedb_postgres.c
index e5504e64..b7a0e819 100644
--- a/src/exchangedb/plugin_exchangedb_postgres.c
+++ b/src/exchangedb/plugin_exchangedb_postgres.c
@@ -8937,7 +8937,6 @@ struct Work
  *
  * @param cls the `struct PostgresClosure` with the plugin-specific state
  * @param coin_pub coin to investigate
- * @param include_recoup should recoup transactions be included in the @a tlp
  * @param[out] tlp set to list of transactions, NULL if coin is fresh
  * @return database transaction status
  */
@@ -8945,26 +8944,10 @@ static enum GNUNET_DB_QueryStatus
 postgres_get_coin_transactions (
   void *cls,
   const struct TALER_CoinSpendPublicKeyP *coin_pub,
-  bool include_recoup,
   struct TALER_EXCHANGEDB_TransactionList **tlp)
 {
   struct PostgresClosure *pg = cls;
-  static const struct Work work_op[] = {
-    /** #TALER_EXCHANGEDB_TT_DEPOSIT */
-    { "get_deposit_with_coin_pub",
-      &add_coin_deposit },
-    /** #TALER_EXCHANGEDB_TT_MELT */
-    { "get_refresh_session_by_coin",
-      &add_coin_melt },
-    /** #TALER_EXCHANGEDB_TT_PURSE_DEPOSIT */
-    { "get_purse_deposit_by_coin_pub",
-      &add_coin_purse_deposit },
-    /** #TALER_EXCHANGEDB_TT_REFUND */
-    { "get_refunds_by_coin",
-      &add_coin_refund },
-    { NULL, NULL }
-  };
-  static const struct Work work_wp[] = {
+  static const struct Work work[] = {
     /** #TALER_EXCHANGEDB_TT_DEPOSIT */
     { "get_deposit_with_coin_pub",
       &add_coin_deposit },
@@ -8993,7 +8976,6 @@ postgres_get_coin_transactions (
     GNUNET_PQ_query_param_end
   };
   enum GNUNET_DB_QueryStatus qs;
-  const struct Work *work;
   struct CoinHistoryContext chc = {
     .head = NULL,
     .coin_pub = coin_pub,
@@ -9001,7 +8983,6 @@ postgres_get_coin_transactions (
     .db_cls = cls
   };
 
-  work = (GNUNET_YES == include_recoup) ? work_wp : work_op;
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Getting transactions for coin %s\n",
               TALER_B2S (coin_pub));
diff --git a/src/exchangedb/test_exchangedb.c b/src/exchangedb/test_exchangedb.c
index 54601c48..b6b8a46b 100644
--- a/src/exchangedb/test_exchangedb.c
+++ b/src/exchangedb/test_exchangedb.c
@@ -1707,7 +1707,6 @@ run (void *cls)
 
       qs = plugin->get_coin_transactions (plugin->cls,
                                           &refresh.coin.coin_pub,
-                                          GNUNET_YES,
                                           &tl);
       FAILIF (GNUNET_DB_STATUS_SUCCESS_ONE_RESULT != qs);
       plugin->free_coin_transaction_list (plugin->cls,
@@ -1946,7 +1945,6 @@ run (void *cls)
   FAILIF (1 != auditor_row_cnt);
   qs = plugin->get_coin_transactions (plugin->cls,
                                       &refund.coin.coin_pub,
-                                      GNUNET_YES,
                                       &tl);
   FAILIF (GNUNET_DB_STATUS_SUCCESS_ONE_RESULT != qs);
   GNUNET_assert (NULL != tl);
diff --git a/src/include/taler_exchangedb_plugin.h 
b/src/include/taler_exchangedb_plugin.h
index 23b2702e..48f0ff99 100644
--- a/src/include/taler_exchangedb_plugin.h
+++ b/src/include/taler_exchangedb_plugin.h
@@ -3838,14 +3838,12 @@ struct TALER_EXCHANGEDB_Plugin
    *
    * @param cls the @e cls of this struct with the plugin-specific state
    * @param coin_pub coin to investigate
-   * @param include_recoup include recoup transactions of the coin?
    * @param[out] tlp set to list of transactions, NULL if coin is fresh
    * @return database transaction status
    */
   enum GNUNET_DB_QueryStatus
   (*get_coin_transactions)(void *cls,
                            const struct TALER_CoinSpendPublicKeyP *coin_pub,
-                           bool include_recoup,
                            struct TALER_EXCHANGEDB_TransactionList **tlp);
 
 

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.