gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[libmicrohttpd] 01/02: Remove double adding of MHD_HTTP_HEADER_CONNECTIO


From: gnunet
Subject: [libmicrohttpd] 01/02: Remove double adding of MHD_HTTP_HEADER_CONNECTION response header
Date: Wed, 15 Jun 2022 14:34:44 +0200

This is an automated email from the git hooks/post-receive script.

karlson2k pushed a commit to branch master
in repository libmicrohttpd.

commit 3526ff83027997ccf360b4729dbfef9aa97f236d
Author: Alexander Irion <alexander_irion@mentor.com>
AuthorDate: Wed Jun 15 12:34:49 2022 +0200

    Remove double adding of MHD_HTTP_HEADER_CONNECTION response header
    
    MHD_create_response_for_upgrade() already adds the 
MHD_HTTP_HEADER_CONNECTION response header, so
    the additional MHD_add_response_header is wrong.
    
    In our application it caused, that on a Apple iPad, the websocket was 
immediately closed by the
    browser(Safari, Chrome, Opera) after the protocol upgrade. Browsers on 
Linux, Android did not had this issue.
    
    Signed-off-by: Alexander Irion <alexander_irion@mentor.com>
---
 src/examples/websocket_chatserver_example.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/examples/websocket_chatserver_example.c 
b/src/examples/websocket_chatserver_example.c
index cc3005a2..cd5940db 100644
--- a/src/examples/websocket_chatserver_example.c
+++ b/src/examples/websocket_chatserver_example.c
@@ -2241,9 +2241,6 @@ access_handler (void *cls,
        * It requires the value of the Sec-WebSocket-Key header of the request.
        * See also: https://tools.ietf.org/html/rfc6455#section-4.2.2
        */
-      MHD_add_response_header (response,
-                               MHD_HTTP_HEADER_CONNECTION,
-                               "Upgrade");
       MHD_add_response_header (response,
                                MHD_HTTP_HEADER_UPGRADE,
                                "websocket");

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]