gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[taler-docs] branch master updated: address CG's spec comment


From: gnunet
Subject: [taler-docs] branch master updated: address CG's spec comment
Date: Mon, 16 Aug 2021 13:02:11 +0200

This is an automated email from the git hooks/post-receive script.

dold pushed a commit to branch master
in repository docs.

The following commit(s) were added to refs/heads/master by this push:
     new 73acf39  address CG's spec comment
73acf39 is described below

commit 73acf3905c6e628f1022c706557c4955d52e13b6
Author: Florian Dold <florian@dold.me>
AuthorDate: Mon Aug 16 13:02:05 2021 +0200

    address CG's spec comment
---
 merchant-spec/public-orders-get.ts | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/merchant-spec/public-orders-get.ts 
b/merchant-spec/public-orders-get.ts
index ef9eee3..4a98aab 100644
--- a/merchant-spec/public-orders-get.ts
+++ b/merchant-spec/public-orders-get.ts
@@ -59,14 +59,9 @@ function handlePublicOrdersGet(mos: MerchantOrderStore, req: 
Req): Resp {
     (ord.requireClaimToken && ord.claimToken === req.claimToken) ||
     !ord.requireClaimToken;
 
-  if (authMissing) {
-    // Client is trying to get the order status of a claimed,
-    // unpaid order.  However, the client is not showing authentication.
-    //
-    // CG-FIXME: Eh, nothing here suggests the order is _claimed_.
-    // The branch above is wrong, as an unclaimed order without
-    // requireClaimToken must not end up here! So I think
-    // we here need authMissing && !authOk in the branch above!
+  if (authMissing && ord.requireClaimToken) {
+    // Client is trying to get the order status of an
+    // order.  However, the client is not showing authentication.
     //
     // This can happen when the fulfillment URL includes the order ID,
     // and the storefront redirects the user to the backend QR code

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]