[taler-exchange] branch master updated (99cbc5fb -> ce5e9f0e)

[gnunet]

This is an automated email from the git hooks/post-receive script.

dold pushed a change to branch master
in repository exchange.

    from 99cbc5fb -improve logging
     new 07bcff12 call chmod on client socket path, not client socket directory
     new ce5e9f0e debian: bump version

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 debian/changelog                                   |  6 ++++++
 .../taler/conf.d/exchange-system.conf              |  1 -
 src/util/crypto_helper_denom.c                     | 23 ++++++++++++++-------
 src/util/crypto_helper_esign.c                     | 24 +++++++++++++++-------
 4 files changed, 39 insertions(+), 15 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 9f0aa782..58a34b71 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+taler-exchange (0.9.0-23) unstable; urgency=low
+
+  * Fix secmod helper permissions.
+
+ -- Florian Dold <dold@taler.net>  Wed, 04 Aug 2021 20:01:12 +0200
+
 taler-exchange (0.9.0-22) unstable; urgency=low
 
   * Fix permissions.
diff --git a/debian/etc-taler-exchange/taler/conf.d/exchange-system.conf 
b/debian/etc-taler-exchange/taler/conf.d/exchange-system.conf
index 7fb65d98..75c670f7 100644
--- a/debian/etc-taler-exchange/taler/conf.d/exchange-system.conf
+++ b/debian/etc-taler-exchange/taler/conf.d/exchange-system.conf
@@ -2,7 +2,6 @@
 
 # Read secret sections into configuration, but only
 # if we have permission to do so.
-@inline-secret@ exchange-account-1 ../secrets/exchange-accounts.secret.conf
 @inline-secret@ exchangedb-postgres ../secrets/exchange-db.secret.conf
 
 [exchange]
diff --git a/src/util/crypto_helper_denom.c b/src/util/crypto_helper_denom.c
index 2cc140c8..243dd296 100644
--- a/src/util/crypto_helper_denom.c
+++ b/src/util/crypto_helper_denom.c
@@ -142,14 +142,23 @@ try_connect (struct TALER_CRYPTO_DenominationHelper *dh)
     GNUNET_free (tmpdir);
     return;
   }
-  /* Fix permissions on UNIX domain socket, just
-     in case umask() is not set to enable group write */
-  if (0 != chmod (tmpdir,
-                  S_IRUSR | S_IWUSR | S_IWGRP))
+  /* Fix permissions on client UNIX domain socket,
+     just in case umask() is not set to enable group write */
   {
-    GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
-                              "chmod",
-                              tmpdir);
+    char path[sizeof (dh->my_sa) + 1];
+
+    strncpy (path,
+             (const char *) &dh->my_sa,
+             sizeof (dh->my_sa));
+    path[sizeof (dh->my_sa)] = '\0';
+
+    if (0 != chmod (path,
+                    S_IRUSR | S_IWUSR | S_IWGRP))
+    {
+      GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
+                                "chmod",
+                                path);
+    }
   }
   GNUNET_free (tmpdir);
   {
diff --git a/src/util/crypto_helper_esign.c b/src/util/crypto_helper_esign.c
index d5baa934..1234ba4a 100644
--- a/src/util/crypto_helper_esign.c
+++ b/src/util/crypto_helper_esign.c
@@ -143,15 +143,25 @@ try_connect (struct TALER_CRYPTO_ExchangeSignHelper *esh)
     GNUNET_free (tmpdir);
     return;
   }
-  /* Fix permissions on UNIX domain socket, just
-     in case umask() is not set to enable group write */
-  if (0 != chmod (tmpdir,
-                  S_IRUSR | S_IWUSR | S_IWGRP))
+  /* Fix permissions on client UNIX domain socket,
+     just in case umask() is not set to enable group write */
   {
-    GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
-                              "chmod",
-                              tmpdir);
+    char path[sizeof (esh->my_sa) + 1];
+
+    strncpy (path,
+             (const char *) &esh->my_sa,
+             sizeof (esh->my_sa));
+    path[sizeof (esh->my_sa)] = '\0';
+
+    if (0 != chmod (path,
+                    S_IRUSR | S_IWUSR | S_IWGRP))
+    {
+      GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
+                                "chmod",
+                                path);
+    }
   }
+
   GNUNET_free (tmpdir);
   {
     struct GNUNET_MessageHeader hdr = {

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.