[taler-wallet-core] branch master updated: better docker instructions

[gnunet]

This is an automated email from the git hooks/post-receive script.

dold pushed a commit to branch master
in repository wallet-core.

The following commit(s) were added to refs/heads/master by this push:
     new f2bbe872 better docker instructions
f2bbe872 is described below

commit f2bbe872cf9e668045bca8f8df604d4298f4f475
Author: Florian Dold <florian@dold.me>
AuthorDate: Wed Nov 25 18:27:58 2020 +0100

    better docker instructions
---
 README                                        | 25 +++++++++++++++++++------
 packages/taler-wallet-webextension/.gitignore |  2 +-
 packages/taler-wallet-webextension/pack.sh    |  4 +++-
 3 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/README b/README
index 0a160023..577c0a3a 100644
--- a/README
+++ b/README
@@ -32,24 +32,37 @@ The WebExtension can be built via the 'webextension' make 
target:
 ./configure && make webextension
 ```
 
-This will create the zip file with the WebExtension in the location
+This will create the zip file with the WebExtension in the directory
 
 ```
-packages/taler-wallet-webextension/taler-wallet-webextension-$VERSION.zip
+packages/taler-wallet-webextension/extension/
 ```
 
 We also provide a `Dockerfile` for a container that can build the WebExtension:
 
 ```shell
+# Download wallet source code and unpack it
+(host)$ tar -xf wallet-core-$version.tar.gz
+
 # Build the image
-(host)$ docker build --tag walletbuilder contrib/wallet-docker
+(host)$ docker build --tag walletbuilder 
wallet-core-$version/contrib/wallet-docker
+
+# Start the container
+(host)$ docker run -dti --name walletcontainer walletbuilder /bin/bash
 
-# Run container with wallet source mounted
-(host)$ docker run -it -v $PWD:/wallet-core walletbuilder
+# Copy wallet source to container
+(host)$ docker cp ./wallet-core-$version/ walletcontainer:/
+
+# Attach to container
+(host)$ docker attach walletcontainer
 
 # Run build inside container
-(container)$ cd wallet-core
+(container)$ cd wallet-core-$version
 (container)$ ./configure && make webextension
+(container)$ exit
+
+# Copy build artefact(s) to host
+(host)$ docker cp 
walletcontainer:/wallet-core-$version/packages/taler-wallet-webextension/extension
 extension
 ```
 
 
diff --git a/packages/taler-wallet-webextension/.gitignore 
b/packages/taler-wallet-webextension/.gitignore
index a6178770..076e5515 100644
--- a/packages/taler-wallet-webextension/.gitignore
+++ b/packages/taler-wallet-webextension/.gitignore
@@ -1 +1 @@
-taler-wallet-*.zip
+extension/
diff --git a/packages/taler-wallet-webextension/pack.sh 
b/packages/taler-wallet-webextension/pack.sh
index 48ec522d..df8d9d54 100755
--- a/packages/taler-wallet-webextension/pack.sh
+++ b/packages/taler-wallet-webextension/pack.sh
@@ -17,5 +17,7 @@ cp -r dist static tmp/
 cd tmp
 zip -r "$zipfile" dist static manifest.json
 cd ..
-mv "./tmp/$zipfile" ./
+mkdir -p extension
+mv "./tmp/$zipfile" ./extension/
 rm -rf tmp
+echo "Packed webextension: extension/$zipfile"

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.