gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[taler-merchant] 253/277: fix FIXME


From: gnunet
Subject: [taler-merchant] 253/277: fix FIXME
Date: Sun, 05 Jul 2020 20:52:46 +0200

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository merchant.

commit 2bc6e492ee9aaa6ed1fa5001b585db4cad76e92e
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Thu Jun 25 11:36:34 2020 +0200

    fix FIXME
---
 src/backend/taler-merchant-httpd_get-orders-ID.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/backend/taler-merchant-httpd_get-orders-ID.c 
b/src/backend/taler-merchant-httpd_get-orders-ID.c
index 40c50de..ca5a1a2 100644
--- a/src/backend/taler-merchant-httpd_get-orders-ID.c
+++ b/src/backend/taler-merchant-httpd_get-orders-ID.c
@@ -850,7 +850,9 @@ TMH_get_orders_ID (const struct TMH_RequestHandler *rh,
                                          TALER_EC_GET_ORDERS_DB_LOOKUP_ERROR,
                                          "db error fetching pay session info");
     }
-    if (0 == qs)
+    if ( (GNUNET_DB_STATUS_SUCCESS_NO_RESULTS == qs) ||
+         (0 != strcmp (order_id,
+                       already_paid_order_id)) )
     {
       MHD_RESULT ret;
 
@@ -860,10 +862,6 @@ TMH_get_orders_ID (const struct TMH_RequestHandler *rh,
       return ret;
     }
     GNUNET_break (1 == qs);
-    // FIXME: eh, what? shouldn't we be possibly REDIRECTING to
-    // already_paid_order_id?
-    GNUNET_break (0 == strcmp (order_id,
-                               already_paid_order_id));
     GNUNET_free_non_null (already_paid_order_id);
   }
   else

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]