[taler-exchange] branch master updated (23cc4a52 -> 6c5155ca)

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a change to branch master
in repository exchange.

    from 23cc4a52 TODO is already done
     new 376277f7 remove bogus comment
     new 6c5155ca Florian says libeufin will reject reserve pubs from 
alternating bank accounts

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/exchangedb/plugin_exchangedb_postgres.c | 20 +-------------------
 src/include/taler_exchangedb_plugin.h       |  4 +---
 2 files changed, 2 insertions(+), 22 deletions(-)

diff --git a/src/exchangedb/plugin_exchangedb_postgres.c 
b/src/exchangedb/plugin_exchangedb_postgres.c
index 8a013c40..edccfa4d 100644
--- a/src/exchangedb/plugin_exchangedb_postgres.c
+++ b/src/exchangedb/plugin_exchangedb_postgres.c
@@ -1847,8 +1847,7 @@ reserves_update (void *cls,
 
 /**
  * Insert an incoming transaction into reserves.  New reserves are also created
- * through this function.  Note that this API call starts (and stops) its
- * own transaction scope (so the application must not do so).
+ * through this function.
  *
  * @param cls the `struct PostgresClosure` with the plugin-specific state
  * @param session the database connection handle
@@ -1886,23 +1885,6 @@ postgres_reserves_in_insert (void *cls,
     GNUNET_break (GNUNET_DB_STATUS_SOFT_ERROR == reserve_exists);
     return reserve_exists;
   }
-  if ( (0 == reserve.balance.value) &&
-       (0 == reserve.balance.fraction) )
-  {
-    /* TODO: reserve balance is empty, we might want to update
-       sender_account_details here.  (So that IF a customer uses the
-       same reserve public key from a different account, we USUALLY
-       switch to the new account (but only if the old reserve was
-       drained).)  This helps make sure that on reserve expiration the
-       funds go back to a valid account in cases where the customer
-       has closed the old bank account and some (buggy?) wallet keeps
-       using the same reserve key with the customer's new account.
-
-       Note that for a non-drained reserve we should not switch,
-       as that opens an attack vector for an adversary who can see
-       the wire transfer subjects (i.e. when using Bitcoin).
-    */}
-
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Creating reserve %s with expiration in %s\n",
               TALER_B2S (reserve_pub),
diff --git a/src/include/taler_exchangedb_plugin.h 
b/src/include/taler_exchangedb_plugin.h
index 3631f475..e3798c53 100644
--- a/src/include/taler_exchangedb_plugin.h
+++ b/src/include/taler_exchangedb_plugin.h
@@ -1727,9 +1727,7 @@ struct TALER_EXCHANGEDB_Plugin
 
   /**
    * Insert a incoming transaction into reserves.  New reserves are
-   * also created through this function.  Note that this API call
-   * starts (and stops) its own transaction scope (so the application
-   * must not do so).
+   * also created through this function.
    *
    * @param cls the @e cls of this struct with the plugin-specific state
    * @param db the database connection handle

-- 
To stop receiving notification emails like this one, please contact
address@hidden.