[taler-exchange] branch master updated: pointless to check denom_sig, do not return

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository exchange.

The following commit(s) were added to refs/heads/master by this push:
     new 19922fa0 pointless to check denom_sig, do not return
19922fa0 is described below

commit 19922fa0464752b989268778e8d6a13eb0fe4964
Author: Christian Grothoff <address@hidden>
AuthorDate: Thu Jan 16 22:21:18 2020 +0100

    pointless to check denom_sig, do not return
---
 src/auditor/taler-auditor.c                 | 7 -------
 src/exchangedb/plugin_exchangedb_postgres.c | 5 -----
 src/exchangedb/test_exchangedb.c            | 2 --
 src/include/taler_exchangedb_plugin.h       | 3 ---
 4 files changed, 17 deletions(-)

diff --git a/src/auditor/taler-auditor.c b/src/auditor/taler-auditor.c
index d2bc3404..afce190e 100644
--- a/src/auditor/taler-auditor.c
+++ b/src/auditor/taler-auditor.c
@@ -1095,7 +1095,6 @@ handle_reserve_in (void *cls,
  * @param rowid unique serial ID for the refresh session in our DB
  * @param h_blind_ev blinded hash of the coin's public key
  * @param denom_pub public denomination key of the deposited coin
- * @param denom_sig signature over the deposited coin
  * @param reserve_pub public key of the reserve
  * @param reserve_sig signature over the withdraw operation
  * @param execution_date when did the wallet withdraw the coin
@@ -1107,7 +1106,6 @@ handle_reserve_out (void *cls,
                     uint64_t rowid,
                     const struct GNUNET_HashCode *h_blind_ev,
                     const struct TALER_DenominationPublicKey *denom_pub,
-                    const struct TALER_DenominationSignature *denom_sig,
                     const struct TALER_ReservePublicKeyP *reserve_pub,
                     const struct TALER_ReserveSignatureP *reserve_sig,
                     struct GNUNET_TIME_Absolute execution_date,
@@ -1123,9 +1121,6 @@ handle_reserve_out (void *cls,
   struct GNUNET_TIME_Absolute expire_withdraw;
   enum GNUNET_DB_QueryStatus qs;
 
-  (void) denom_sig; /* FIXME: checked elsewhere? If so, potential for
-                       optimization to simply not fetch this value from DB! */
-
   /* should be monotonically increasing */
   GNUNET_assert (rowid >= ppr.last_reserve_out_serial_id);
   ppr.last_reserve_out_serial_id = rowid + 1;
@@ -3469,7 +3464,6 @@ sync_denomination (void *cls,
  * @param rowid unique serial ID for the refresh session in our DB
  * @param h_blind_ev blinded hash of the coin's public key
  * @param denom_pub public denomination key of the deposited coin
- * @param denom_sig signature over the deposited coin
  * @param reserve_pub public key of the reserve
  * @param reserve_sig signature over the withdraw operation (verified 
elsewhere)
  * @param execution_date when did the wallet withdraw the coin
@@ -3481,7 +3475,6 @@ withdraw_cb (void *cls,
              uint64_t rowid,
              const struct GNUNET_HashCode *h_blind_ev,
              const struct TALER_DenominationPublicKey *denom_pub,
-             const struct TALER_DenominationSignature *denom_sig,
              const struct TALER_ReservePublicKeyP *reserve_pub,
              const struct TALER_ReserveSignatureP *reserve_sig,
              struct GNUNET_TIME_Absolute execution_date,
diff --git a/src/exchangedb/plugin_exchangedb_postgres.c 
b/src/exchangedb/plugin_exchangedb_postgres.c
index 28d8e574..65e52e67 100644
--- a/src/exchangedb/plugin_exchangedb_postgres.c
+++ b/src/exchangedb/plugin_exchangedb_postgres.c
@@ -854,7 +854,6 @@ postgres_get_session (void *cls)
                               "SELECT"
                               " h_blind_ev"
                               ",denom.denom_pub"
-                              ",denom_sig"
                               ",reserve_sig"
                               ",reserve_pub"
                               ",execution_date"
@@ -6386,7 +6385,6 @@ reserves_out_serial_helper_cb (void *cls,
   {
     struct GNUNET_HashCode h_blind_ev;
     struct TALER_DenominationPublicKey denom_pub;
-    struct TALER_DenominationSignature denom_sig;
     struct TALER_ReservePublicKeyP reserve_pub;
     struct TALER_ReserveSignatureP reserve_sig;
     struct GNUNET_TIME_Absolute execution_date;
@@ -6397,8 +6395,6 @@ reserves_out_serial_helper_cb (void *cls,
                                             &h_blind_ev),
       GNUNET_PQ_result_spec_rsa_public_key ("denom_pub",
                                             &denom_pub.rsa_public_key),
-      GNUNET_PQ_result_spec_rsa_signature ("denom_sig",
-                                           &denom_sig.rsa_signature),
       GNUNET_PQ_result_spec_auto_from_type ("reserve_pub",
                                             &reserve_pub),
       GNUNET_PQ_result_spec_auto_from_type ("reserve_sig",
@@ -6426,7 +6422,6 @@ reserves_out_serial_helper_cb (void *cls,
                     rowid,
                     &h_blind_ev,
                     &denom_pub,
-                    &denom_sig,
                     &reserve_pub,
                     &reserve_sig,
                     execution_date,
diff --git a/src/exchangedb/test_exchangedb.c b/src/exchangedb/test_exchangedb.c
index 583e3c17..73d89e0b 100644
--- a/src/exchangedb/test_exchangedb.c
+++ b/src/exchangedb/test_exchangedb.c
@@ -969,7 +969,6 @@ audit_reserve_in_cb (void *cls,
  * @param rowid unique serial ID for the refresh session in our DB
  * @param h_blind_ev blinded hash of the coin's public key
  * @param denom_pub public denomination key of the deposited coin
- * @param denom_sig signature over the deposited coin
  * @param reserve_pub public key of the reserve
  * @param reserve_sig signature over the withdraw operation
  * @param execution_date when did the wallet withdraw the coin
@@ -981,7 +980,6 @@ audit_reserve_out_cb (void *cls,
                       uint64_t rowid,
                       const struct GNUNET_HashCode *h_blind_ev,
                       const struct TALER_DenominationPublicKey *denom_pub,
-                      const struct TALER_DenominationSignature *denom_sig,
                       const struct TALER_ReservePublicKeyP *reserve_pub,
                       const struct TALER_ReserveSignatureP *reserve_sig,
                       struct GNUNET_TIME_Absolute execution_date,
diff --git a/src/include/taler_exchangedb_plugin.h 
b/src/include/taler_exchangedb_plugin.h
index 09e3b180..06be27e0 100644
--- a/src/include/taler_exchangedb_plugin.h
+++ b/src/include/taler_exchangedb_plugin.h
@@ -983,7 +983,6 @@ typedef int
  * @param rowid unique serial ID for the refresh session in our DB
  * @param h_blind_ev blinded hash of the coin's public key
  * @param denom_pub public denomination key of the deposited coin
- * @param denom_sig signature over the deposited coin
  * @param reserve_pub public key of the reserve
  * @param reserve_sig signature over the withdraw operation
  * @param execution_date when did the wallet withdraw the coin
@@ -997,8 +996,6 @@ typedef int
                                      const struct
                                      TALER_DenominationPublicKey *denom_pub,
                                      const struct
-                                     TALER_DenominationSignature *denom_sig,
-                                     const struct
                                      TALER_ReservePublicKeyP *reserve_pub,
                                      const struct
                                      TALER_ReserveSignatureP *reserve_sig,

-- 
To stop receiving notification emails like this one, please contact
address@hidden.