[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnurl] 09/18: create_conn: prefer multiplexing to using new connections
From: |
gnunet |
Subject: |
[gnurl] 09/18: create_conn: prefer multiplexing to using new connections |
Date: |
Fri, 20 Dec 2019 14:49:11 +0100 |
This is an automated email from the git hooks/post-receive script.
ng0 pushed a commit to branch master
in repository gnurl.
commit 8c0807aa161d791fa94da2e19e46b8cf845fd5d1
Author: Daniel Stenberg <address@hidden>
AuthorDate: Wed Dec 18 14:03:36 2019 +0100
create_conn: prefer multiplexing to using new connections
... as it would previously prefer new connections rather than
multiplexing in most conditions! The (now removed) code was a leftover
from the Pipelining code that was translated wrongly into a
multiplex-only world.
Reported-by: Kunal Ekawde
Bug: https://curl.haxx.se/mail/lib-2019-12/0060.html
Closes #4732
---
lib/url.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/lib/url.c b/lib/url.c
index 4111eec3a..56fb73636 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -3594,24 +3594,6 @@ static CURLcode create_conn(struct Curl_easy *data,
else
reuse = ConnectionExists(data, conn, &conn_temp, &force_reuse, &waitpipe);
- /* If we found a reusable connection that is now marked as in use, we may
- still want to open a new connection if we are multiplexing. */
- if(reuse && !force_reuse && IsMultiplexingPossible(data, conn_temp)) {
- size_t multiplexed = CONN_INUSE(conn_temp);
- if(multiplexed > 0) {
- infof(data, "Found connection %ld, with %zu requests on it\n",
- conn_temp->connection_id, multiplexed);
-
- if(Curl_conncache_bundle_size(conn_temp) < max_host_connections &&
- Curl_conncache_size(data) < max_total_connections) {
- /* We want a new connection anyway */
- reuse = FALSE;
-
- infof(data, "We can reuse, but we want a new connection anyway\n");
- }
- }
- }
-
if(reuse) {
/*
* We already have a connection for this, we got the former connection
--
To stop receiving notification emails like this one, please contact
address@hidden.
- [gnurl] branch master updated (486ada36f -> 71b588320), gnunet, 2019/12/20
- [gnurl] 03/18: CURLOPT_URL.3: "curl supports SMB version 1 (only)", gnunet, 2019/12/20
- [gnurl] 01/18: HISTORY: the SMB(S) support landed in 2014, gnunet, 2019/12/20
- [gnurl] 10/18: curl.h: add two defines for the "pre ISO C" case, gnunet, 2019/12/20
- [gnurl] 02/18: test1270: a basic -w redirect_url test, gnunet, 2019/12/20
- [gnurl] 06/18: strerror: Fix compiler warning "empty expression", gnunet, 2019/12/20
- [gnurl] 07/18: CURLOPT_QUOTE.3: fix typos, gnunet, 2019/12/20
- [gnurl] 08/18: test1456: remove the use of a fixed local port, gnunet, 2019/12/20
- [gnurl] 05/18: curl/parseconfig: use curl_free() to free memory allocated by libcurl, gnunet, 2019/12/20
- [gnurl] 04/18: curl/parseconfig: fix mem-leak, gnunet, 2019/12/20
- [gnurl] 09/18: create_conn: prefer multiplexing to using new connections,
gnunet <=
- [gnurl] 16/18: HISTORY: OSS-Fuzz started fuzzing libcurl in 2017, gnunet, 2019/12/20
- [gnurl] 11/18: test165: set LC_ALL=en_US.UTF-8 too, gnunet, 2019/12/20
- [gnurl] 13/18: sws: search for "Testno:" header uncondtionally if no testno, gnunet, 2019/12/20
- [gnurl] 17/18: examples/url2file.c: corrected a comment, gnunet, 2019/12/20
- [gnurl] 12/18: tests: set LC_ALL in more tests, gnunet, 2019/12/20
- [gnurl] 14/18: ngtcp2: Support the latest update key callback type, gnunet, 2019/12/20
- [gnurl] 15/18: RELEASE-NOTES: synced, gnunet, 2019/12/20
- [gnurl] 18/18: Merge branch 'master' of https://github.com/curl/curl, gnunet, 2019/12/20