[gnurl] 71/222: curl: exit the create_transfers loop on errors

[gnunet]

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit f8a205853381650ea1b7e05abec93cd0ae2b77b5
Author: Daniel Stenberg <address@hidden>
AuthorDate: Sat Sep 21 23:46:41 2019 +0200

    curl: exit the create_transfers loop on errors
    
    When looping around the ranges and given URLs to create transfers, all
    errors should exit the loop and return. Previously it would keep
    looping.
    
    Reported-by: SumatraPeter on github
    Bug: #4393
    Closes #4396
---
 src/tool_operate.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/tool_operate.c b/src/tool_operate.c
index 316951869..ede816d34 100644
--- a/src/tool_operate.c
+++ b/src/tool_operate.c
@@ -1885,15 +1885,9 @@ static CURLcode create_transfers(struct GlobalConfig 
*global,
         urls = NULL;
       }
 
-      if(infilenum > 1) {
-        /* when file globbing, exit loop upon critical error */
-        if(is_fatal_error(result))
-          break;
-      }
-      else if(result)
-        /* when not file globbing, exit loop upon any error */
+      if(result)
+        /* exit loop upon error */
         break;
-
     } /* loop to the next globbed upload file */
 
     /* Free loop-local allocated memory */
@@ -1913,6 +1907,9 @@ static CURLcode create_transfers(struct GlobalConfig 
*global,
     Curl_safefree(urlnode->infile);
     urlnode->flags = 0;
 
+    if(result)
+      /* exit loop upon error */
+      break;
   } /* for-loop through all URLs */
   quit_curl:
 

-- 
To stop receiving notification emails like this one, please contact
address@hidden.