[gnurl] 41/222: ftp: the conditional expression is always true

[gnunet]

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit e3c41ebd7c6f31f0a30362cfda735cdebb400ced
Author: Daniel Stenberg <address@hidden>
AuthorDate: Thu Sep 19 09:19:44 2019 +0200

    ftp: the conditional expression is always true
    
    ... both !result and (ftp->transfer != FTPTRANSFER_BODY)!
    
    Fixes warning detected by PVS-Studio
    Fixes #4374
---
 lib/ftp.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/ftp.c b/lib/ftp.c
index 4cd9a1acf..d057a0a61 100644
--- a/lib/ftp.c
+++ b/lib/ftp.c
@@ -3611,10 +3611,8 @@ static CURLcode ftp_do_more(struct connectdata *conn, 
int *completep)
     return result;
   }
 
-  if(!result && (ftp->transfer != FTPTRANSFER_BODY))
-    /* no data to transfer. FIX: it feels like a kludge to have this here
-       too! */
-    Curl_setup_transfer(data, -1, -1, FALSE, -1);
+  /* no data to transfer */
+  Curl_setup_transfer(data, -1, -1, FALSE, -1);
 
   if(!ftpc->wait_data_conn) {
     /* no waiting for the data connection so this is now complete */

-- 
To stop receiving notification emails like this one, please contact
address@hidden.