gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] [gnurl] 98/116: connect: improve the bind error message


From: gnunet
Subject: [GNUnet-SVN] [gnurl] 98/116: connect: improve the bind error message
Date: Tue, 05 Dec 2017 14:52:08 +0100

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit 31f18d27224f65249e719d87f5a5109378b3e420
Author: Jay Satiro <address@hidden>
AuthorDate: Thu Nov 23 02:47:26 2017 -0500

    connect: improve the bind error message
    
    eg consider a non-existent interface eth8, curl --interface eth8
    
    Before: curl: (45) Could not resolve host: eth8
    After: curl: (45) Couldn't bind to 'eth8'
    
    Bug: https://github.com/curl/curl/issues/2104
    Reported-by: Alfonso Martone
---
 lib/connect.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/connect.c b/lib/connect.c
index 16104bc4f..45e18bc07 100644
--- a/lib/connect.c
+++ b/lib/connect.c
@@ -412,6 +412,10 @@ static CURLcode bindlocal(struct connectdata *conn,
     }
 
     if(done < 1) {
+      /* errorbuf is set false so failf will overwrite any message already in
+         the error buffer, so the user receives this error message instead of a
+         generic resolve error. */
+      data->state.errorbuf = FALSE;
       failf(data, "Couldn't bind to '%s'", dev);
       return CURLE_INTERFACE_FAILED;
     }

-- 
To stop receiving notification emails like this one, please contact
address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]