gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] [gnurl] 21/208: mk-ca-bundle.pl: Check curl's exit code aft


From: gnunet
Subject: [GNUnet-SVN] [gnurl] 21/208: mk-ca-bundle.pl: Check curl's exit code after certdata download
Date: Wed, 09 Aug 2017 17:33:38 +0200

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to annotated tag gnurl-7.55.0
in repository gnurl.

commit ec92afc3f4b2ecdd26b01b6a59e8fbddd5783e67
Author: Jay Satiro <address@hidden>
AuthorDate: Fri Jun 16 01:58:23 2017 -0400

    mk-ca-bundle.pl: Check curl's exit code after certdata download
    
    - No longer allow partial downloads of certdata.
    
    Prior to this change partial downloads were (erroneously?) allowed since
    only the server code was checked to be 200.
    
    Bug: https://github.com/curl/curl/pull/1577
    Reported-by: Matteo B.
---
 lib/mk-ca-bundle.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/mk-ca-bundle.pl b/lib/mk-ca-bundle.pl
index 9574f1dbf..cc36c7680 100755
--- a/lib/mk-ca-bundle.pl
+++ b/lib/mk-ca-bundle.pl
@@ -310,7 +310,7 @@ if(!$opt_n) {
         my $proto = !$opt_k ? "--proto =https" : "";
         my $quiet = $opt_q ? "-s" : "";
         my @out = `curl -w %{response_code} $proto $quiet -o "$txt" "$url"`;
-        if(@out && $out[0] == 200) {
+        if(!$? && @out && $out[0] == 200) {
           $fetched = 1;
           report "Downloaded $txt";
         }

-- 
To stop receiving notification emails like this one, please contact
address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]