gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] [taler-bank] branch master updated: more diagnostics for #5


From: gnunet
Subject: [GNUnet-SVN] [taler-bank] branch master updated: more diagnostics for #5033
Date: Mon, 29 May 2017 10:53:01 +0200

This is an automated email from the git hooks/post-receive script.

marcello pushed a commit to branch master
in repository bank.

The following commit(s) were added to refs/heads/master by this push:
     new 9430850  more diagnostics for #5033
9430850 is described below

commit 94308507fbbc5b67a3d88029032ad6fc8d4bb987
Author: Marcello Stanisci <address@hidden>
AuthorDate: Mon May 29 10:53:05 2017 +0200

    more diagnostics for #5033
---
 talerbank/app/views.py | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/talerbank/app/views.py b/talerbank/app/views.py
index 009578b..c3bed3e 100644
--- a/talerbank/app/views.py
+++ b/talerbank/app/views.py
@@ -137,11 +137,20 @@ def pin_tan_question(request):
         if param not in request.GET:
             return HttpResponseBadRequest("parameter {} missing".format(param))
     try:
-        amount = {"value": int(request.GET["amount_value"]),
-                  "fraction": int(request.GET["amount_fraction"]),
-                  "currency": request.GET["amount_currency"]}
+        value = int(request.GET.get("amount_value", None))
     except ValueError:
-        return HttpResponseBadRequest("invalid parameters")
+        return HttpResponseBadRequest("invalid parameters: \"amount_value\" 
not given or NaN")
+    try:
+        fraction = int(request.GET.get("amount_fraction", None))
+    except ValueError:
+        return HttpResponseBadRequest("invalid parameters: \"amount_fraction\" 
not given or NaN")
+    try:
+        currency = request.GET.get("amount_currency", None)
+    except ValueError:
+        return HttpResponseBadRequest("invalid parameters: \"amount_currency\" 
not given")
+    amount = {"value": value,
+              "fraction": fraction,
+              "currency": currency}
     user_account = BankAccount.objects.get(user=request.user)
     wiredetails = json.loads(request.GET["wire_details"])
     if not isinstance(wiredetails, dict) or "test" not in wiredetails:
@@ -151,8 +160,8 @@ def pin_tan_question(request):
     try:
         schemas.validate_wiredetails(wiredetails)
         schemas.validate_amount(amount)
-    except ValueError:
-        return HttpResponseBadRequest("invalid parameters")
+    except ValueError as error:
+        return HttpResponseBadRequest("invalid parameters (%s)" % error)
     # parameters we store in the session are (more or less) validated
     request.session["exchange_account_number"] = 
wiredetails["test"]["account_number"]
     request.session["amount"] = amount

-- 
To stop receiving notification emails like this one, please contact
address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]