[GNUnet-SVN] [taler-exchange] branch master updated: check payback signatures in auditor

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository exchange.

The following commit(s) were added to refs/heads/master by this push:
     new 9301012  check payback signatures in auditor
9301012 is described below

commit 930101256eed811b7c7b76b7cb7e8c6f797b03f7
Author: Christian Grothoff <address@hidden>
AuthorDate: Tue Apr 4 17:05:38 2017 +0200

    check payback signatures in auditor
---
 src/auditor/taler-auditor.c | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/src/auditor/taler-auditor.c b/src/auditor/taler-auditor.c
index e89812a..1484c2a 100644
--- a/src/auditor/taler-auditor.c
+++ b/src/auditor/taler-auditor.c
@@ -827,13 +827,36 @@ handle_payback_by_reserve (void *cls,
   struct GNUNET_HashCode key;
   struct ReserveSummary *rs;
   struct GNUNET_TIME_Absolute expiry;
+  struct TALER_PaybackRequestPS pr;
 
   /* should be monotonically increasing */
   GNUNET_assert (rowid >= pp.last_reserve_payback_serial_id);
   pp.last_reserve_payback_serial_id = rowid + 1;
 
-  /* TODO: check that coin signature on payback request is valid
-     and/or that the coin was eligible for payback! #3887!*/
+  if (GNUNET_OK !=
+      TALER_test_coin_valid (coin))
+  {
+    report_row_inconsistency ("payback",
+                              rowid,
+                              "coin denomination signature invalid");
+  }
+  pr.purpose.purpose = htonl (TALER_SIGNATURE_WALLET_COIN_PAYBACK);
+  pr.purpose.size = htonl (sizeof (pr));
+  pr.coin_pub = coin->coin_pub;
+  GNUNET_CRYPTO_rsa_public_key_hash (coin->denom_pub.rsa_public_key,
+                                     &pr.h_denom_pub);
+  pr.coin_blind = *coin_blind;
+  if (GNUNET_OK !=
+      GNUNET_CRYPTO_eddsa_verify (TALER_SIGNATURE_WALLET_COIN_PAYBACK,
+                                  &pr.purpose,
+                                  &coin_sig->eddsa_signature,
+                                  &coin->coin_pub.eddsa_pub))
+  {
+    report_row_inconsistency ("payback",
+                              rowid,
+                              "coin payback signature invalid");
+  }
+  /* TODO: check that the coin was eligible for payback! #3887!*/
 
   GNUNET_CRYPTO_hash (reserve_pub,
                       sizeof (*reserve_pub),

-- 
To stop receiving notification emails like this one, please contact
address@hidden