[GNUnet-SVN] r20380 - in gnunet/src: arm gns util

[gnunet]

Author: grothoff
Date: 2012-03-08 19:17:41 +0100 (Thu, 08 Mar 2012)
New Revision: 20380

Modified:
   gnunet/src/arm/arm_api.c
   gnunet/src/gns/test_gns_dht_delegated_lookup.c
   gnunet/src/util/crypto_rsa.c
Log:
-fixing leaks/use after free

Modified: gnunet/src/arm/arm_api.c
===================================================================
--- gnunet/src/arm/arm_api.c    2012-03-08 18:17:31 UTC (rev 20379)
+++ gnunet/src/arm/arm_api.c    2012-03-08 18:17:41 UTC (rev 20380)
@@ -763,8 +763,8 @@
       if (NULL == end)
       {
        GNUNET_break (0);
+       sc->callback (sc->cls, GNUNET_NO, 0, NULL);
        GNUNET_free (sc);
-       sc->callback (sc->cls, GNUNET_NO, 0, NULL);
        return;
       }
       list[i] = pos;

Modified: gnunet/src/gns/test_gns_dht_delegated_lookup.c
===================================================================
--- gnunet/src/gns/test_gns_dht_delegated_lookup.c      2012-03-08 18:17:31 UTC 
(rev 20379)
+++ gnunet/src/gns/test_gns_dht_delegated_lookup.c      2012-03-08 18:17:41 UTC 
(rev 20380)
@@ -224,6 +224,7 @@
   {
     GNUNET_log(GNUNET_ERROR_TYPE_ERROR, "Record serialization failed!\n");
     ok = 3;
+    GNUNET_free (nrb);
     return;
   }
   GNUNET_CRYPTO_hash(TEST_RECORD_NAME, strlen(TEST_RECORD_NAME), &name_hash);
@@ -244,6 +245,7 @@
                   DHT_OPERATION_TIMEOUT,
                   NULL,
                   NULL);
+  GNUNET_free (nrb);
   GNUNET_SCHEDULER_add_delayed(TIMEOUT, &finish_testing, NULL);
 }
 

Modified: gnunet/src/util/crypto_rsa.c
===================================================================
--- gnunet/src/util/crypto_rsa.c        2012-03-08 18:17:31 UTC (rev 20379)
+++ gnunet/src/util/crypto_rsa.c        2012-03-08 18:17:41 UTC (rev 20380)
@@ -808,6 +808,7 @@
     pk = GNUNET_CRYPTO_rsa_key_create_from_file (fn);
     if (NULL != pk)
       GNUNET_CRYPTO_rsa_key_free (pk);
+    GNUNET_free (fn);
   }
   GNUNET_CONFIGURATION_destroy (cfg);
 }