[GNUnet-SVN] r10458 - in gnunet/src: fs transport

[gnunet]

Author: grothoff
Date: 2010-02-27 13:21:45 +0100 (Sat, 27 Feb 2010)
New Revision: 10458

Modified:
   gnunet/src/fs/fs_test_lib_data.conf
   gnunet/src/fs/test_fs_download_data.conf
   gnunet/src/transport/plugin_transport_tcp.c
Log:
comment

Modified: gnunet/src/fs/fs_test_lib_data.conf
===================================================================
--- gnunet/src/fs/fs_test_lib_data.conf 2010-02-27 12:09:56 UTC (rev 10457)
+++ gnunet/src/fs/fs_test_lib_data.conf 2010-02-27 12:21:45 UTC (rev 10458)
@@ -12,7 +12,7 @@
 [transport]
 PORT = 43465
 PLUGINS = tcp
-#DEBUG = YES
+DEBUG = YES
 
 [arm]
 PORT = 43466
@@ -40,7 +40,7 @@
 HOSTNAME = localhost
 #TOTAL_QUOTA_IN = 3932160
 #TOTAL_QUOTA_OUT = 3932160
-#DEBUG = YES
+DEBUG = YES
 
 [fs]
 PORT = 43471

Modified: gnunet/src/fs/test_fs_download_data.conf
===================================================================
--- gnunet/src/fs/test_fs_download_data.conf    2010-02-27 12:09:56 UTC (rev 
10457)
+++ gnunet/src/fs/test_fs_download_data.conf    2010-02-27 12:21:45 UTC (rev 
10458)
@@ -36,7 +36,7 @@
 [fs]
 PORT = 42471
 HOSTNAME = localhost
-DEBUG = YES
+#DEBUG = YES
 #PREFIX = valgrind --tool=memcheck --leak-check=yes
 #BINARY = /home/grothoff/bin/gnunet-service-fs
 

Modified: gnunet/src/transport/plugin_transport_tcp.c
===================================================================
--- gnunet/src/transport/plugin_transport_tcp.c 2010-02-27 12:09:56 UTC (rev 
10457)
+++ gnunet/src/transport/plugin_transport_tcp.c 2010-02-27 12:21:45 UTC (rev 
10458)
@@ -333,6 +333,7 @@
   ret->client = client;
   ret->target = *target;
   ret->last_quota_update = GNUNET_TIME_absolute_get ();
+  // FIXME: This is simply wrong...
   ret->quota_in = plugin->env->default_quota_in;
   ret->expecting_welcome = GNUNET_YES;
   pm = GNUNET_malloc (sizeof (struct PendingMessage) + sizeof (struct 
WelcomeMessage));
@@ -902,6 +903,15 @@
   struct Plugin *plugin = cls;
   struct Session *session;
 
+  // FIXME: This is simply wrong:
+  // We may have multiple sessions for the target,
+  // and some OTHER session might be the one to 
+  // survive; not to mention the inbound-quota should
+  // be enforced across transports!
+  // => keep quota-related states in the service (globally, per peer)
+  //    and update/query the information when it is needed!
+  // => we can likely get rid of this entire function and
+  //    replace it with a query/update API!
   session = find_session_by_target (plugin, target);
   if (session == NULL)
     {