Re: 'gnunet-namestore' does not honour expiration dates when importing URIs

[Christian Grothoff]

Hi Martin,

Why do you say that PKEY expiration values should have to be 'forever'?
PKEY records have expiration times like any other record and they don't
have to be eternal.

Now, I can see that the main use case (import via URL) may have a
difficulty of passing the '-e' option (and so we might want a sane
default), but that doesn't imply we should ignore -e.

My 2 cents

Christian

On 3/21/20 10:38 AM, Schanzenbach, Martin wrote:
> Hi,
> 
> I doubt this is correct. As far as I can see this imports a PKEY. What means 
> the expiration value must be "forever".
> I also assume that the use case for this import will likely not be able to 
> pass an expiration value.
> 
> BR
> Martin
> 
>> On 21. Mar 2020, at 10:03, Christian Grothoff <address@hidden> wrote:
>>
>> Thanks for the patch, I have applied it.
>>
>> Happy hacking!
>>
>> Christian
>>
>> On 3/20/20 3:42 PM, Alessio Vanni wrote:
>>> Hello,
>>>
>>> as this mail's subject says, running
>>>
>>> gnunet-namestore -e $expiry -u $uri
>>>
>>> ignores the value passed to the '-e' argument, defaulting to the UNIX
>>> time 0 since the relevant variable is global and thus initialized to
>>> that value at startup.  I've attached a patch that fixes the
>>> problem.
>>>
>>> Thank you,
>>> A.V.
>>>
>>
>

signature.asc
Description: OpenPGP digital signature