[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnumed-devel] new gmDemographicRecord
From: |
Karsten Hilbert |
Subject: |
Re: [Gnumed-devel] new gmDemographicRecord |
Date: |
Wed, 15 Dec 2004 09:34:33 +0100 |
User-agent: |
Mutt/1.3.22.1i |
> I have rewritten a lot of gmDemographicRecord, this is to improve speed
> by caching and using few big queries, also it makes the interface look
> more like cClinItem.
>
> This is not fully tested, I just want comments on the general design.
Have you considered deriving your classes from
pycommon/gmBusinessDBObject.py ? If not why not ? Could/should
we then improve gmBusinessDBObject to allow for you using it ?
Have you considered driving cAddress off of a (as yet not
exisiting) table v_pat_address which would already include the
type ?
Defining _idx may be a tad faster but requires a lot more
maintenance on schema changes. Does it really pay off ?
I do like the core -> cOrg -> cPerson approach. However, there
is conceptual overlap with business/gmPatient->gmPerson ...
IMO your cPerson should just become cDemographicRecord which
would be what is returned by
gmPatient.gmPerson.get_demographic_record() ...
I think in that lies where Richard's starting the client
fails, perhaps.
Karsten
--
GPG key ID E4071346 @ wwwkeys.pgp.net
E167 67FD A291 2BEA 73BD 4537 78B9 A9F9 E407 1346