[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[task #13658] Work on concave polygons too

From: Mohammad Akhlaghi
Subject: [task #13658] Work on concave polygons too
Date: Tue, 7 Apr 2020 18:15:46 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0

Follow-up Comment #42, task #13658 (project gnuastro):

One more minor stylistic point: 

When you have a simple test, its much elegant/readable/less-buggy to use the
`?:' structure, rather than repeating something.

For the return value of `polygon_leftof_vector', you have such a statement. So
its better to write it like this:

return test ? (test>0 ? 1 : -1) : 0;

Also, please define variables at the top of functions, not in the middle of
its operations (as discussed in Comment 55 of Task 15567


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]