[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[task #13658] Work on concave polygons too

From: Mohammad Akhlaghi
Subject: [task #13658] Work on concave polygons too
Date: Sun, 5 Apr 2020 17:08:54 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0

Follow-up Comment #39, task #13658 (project gnuastro):

Thanks Sachin, it generally looks good, can you please rebase it so I can
implement it in the Crop program, and close this task?

Or maybe you can also implement it in Crop yourself? Effectively, just
replacing the call to `gal_polygon_vertices_sort_convex' with

I just saw this warning when compiling the branch:

In file included from /path/to/gnuastro/source/bin/crop/onecrop.c:37:
/path/to/gnuastro/source/lib/gnuastro/polygon.h:64:1: warning: useless storage
class specifier in empty declaration
   64 | };
      | ^

Can you please fix it? Generally, you should't put `static' things in a
header! You can put it directly in `polygon.c', it just has to be above the
first instance of its usage ;-).

About Github, you have your own fork there and there is no problem, but Github
is not very liked in the free software community because its not free software
itself (ironic, isn't it?)! GNU has an Ethical Repository Criteria Evaluations
<> which you can
see for more information. For a more modern visual experience, Gitlab is far
better than Github. 

Generally, like many other GNU packages, Gnuastro's main Git repository is on
Savannah's CGIT interface <>.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]