[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnuastro-commits] master b7160e0: MakeCatalog: column area requested wh

From: Mohammad Akhlaghi
Subject: [gnuastro-commits] master b7160e0: MakeCatalog: column area requested when measuring S/N
Date: Tue, 26 Nov 2019 07:10:55 -0500 (EST)

branch: master
commit b7160e0a8138100f8e1002bd0f8cec2986ff0772
Author: Mohammad Akhlaghi <address@hidden>
Commit: Mohammad Akhlaghi <address@hidden>

    MakeCatalog: column area requested when measuring S/N
    Until the previous commit (where the S/N wasn't measured properly!), the
    area wasn't used in the calculation of the clump S/N value. But with the
    previous commit, the number of pixels in the clump (`CCOL_NUM') is also
    used in the clump S/N value.
    However, I had forgot to mark this internal column as a dependency of the
    S/N calculation. Therefore when the area (or another column that was marked
    as needing `CCOL_NUM' like `--mean') wasn't explicitly being requested,
    MakeCatalog wouldn't write a value in that column, so it would remain zero,
    and thus the clump was effectively being treated as an object!
    With this commit, MakeCatalog now knows that the S/N measurement also
    depends on the clump area.
    This was reported by Joseph Putko.
 bin/mkcatalog/columns.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/mkcatalog/columns.c b/bin/mkcatalog/columns.c
index eadd88d..71e15fc 100644
--- a/bin/mkcatalog/columns.c
+++ b/bin/mkcatalog/columns.c
@@ -1263,6 +1263,7 @@ columns_define_alloc(struct mkcatalogparams *p)
           disp_precision = 3;
           oiflag[ OCOL_SUM         ] = ciflag[ CCOL_SUM         ] = 1;
           oiflag[ OCOL_SUM_VAR     ] = ciflag[ CCOL_SUM_VAR     ] = 1;
+                                       ciflag[ CCOL_NUM         ] = 1;
                                        ciflag[ CCOL_RIV_NUM     ] = 1;
                                        ciflag[ CCOL_RIV_SUM     ] = 1;
                                        ciflag[ CCOL_RIV_SUM_VAR ] = 1;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]