[gnuastro-commits] master 4cc7ff4: Book: building and installing shared CFITSIO library

[Mohammad Akhlaghi]

branch: master
commit 4cc7ff4a2274dfe45d86c4b51c224f17fa8d0cd2
Author: Mohammad Akhlaghi <address@hidden>
Commit: Mohammad Akhlaghi <address@hidden>

    Book: building and installing shared CFITSIO library
    
    Until now, the build instructions for CFITSIO as a dependency of Gnuastro
    only built it as a static library. As a result, if the user's computer had
    other shared library installations of CFITSIO (with different versions),
    that would cause an error like below (after the main body of the commit
    message).
    
    After many tests with the help of Elham Saremi, we were able to track down
    this problem and fix it. The fix was to build and install a shared CFITSIO
    library also (not just the default static library). As a result with this
    commit, CFITSIO's installation instructions include `make shared'.
    
    """""
    ERROR: Mismatch in the CFITSIO_SONAME value in the fitsio.h include file
    that was used to build the CFITSIO library, and the value in the include
    file that was used when compiling the application program:
       Version used to build the CFITSIO library   = 2
       Version included by the application program = 7
    
    Fix this by recompiling and then relinking this application program
    with the CFITSIO library.
    """"
---
 THANKS                       | 1 +
 doc/announce-acknowledge.txt | 1 +
 doc/gnuastro.texi            | 1 +
 3 files changed, 3 insertions(+)

diff --git a/THANKS b/THANKS
index 557cd3a..069d240 100644
--- a/THANKS
+++ b/THANKS
@@ -59,6 +59,7 @@ support in Gnuastro. The list is ordered alphabetically (by 
family name).
     Mamta Pommier                        address@hidden
     Bob Proulx                           address@hidden
     Teymoor Saifollahi                   address@hidden
+    Elham Saremi                         address@hidden
     Yahya Sefidbakht                     address@hidden
     Alejandro Serrano Borlaff            address@hidden
     Jenny Sorce                          address@hidden
diff --git a/doc/announce-acknowledge.txt b/doc/announce-acknowledge.txt
index 53e78c9..7e123c6 100644
--- a/doc/announce-acknowledge.txt
+++ b/doc/announce-acknowledge.txt
@@ -3,6 +3,7 @@ Alphabetically ordered list to acknowledge in the next release.
 Leindert Boogaard
 Raul Infante-Sainz
 Lee Kelvin
+Elham Saremi
 David Valls-Gabaud
 
 
diff --git a/doc/gnuastro.texi b/doc/gnuastro.texi
index 096a500..cf7d3f3 100644
--- a/doc/gnuastro.texi
+++ b/doc/gnuastro.texi
@@ -5098,6 +5098,7 @@ $ ./testprog > testprog.lis
 $ diff testprog.lis testprog.out    # Should have no output
 $ cmp testprog.fit testprog.std     # Should have no output
 $ rm cookbook fitscopy imcopy smem speed testprog
+$ make shared
 $ sudo make install
 @end example