gnuastro-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnuastro-commits] master 0ad3717: gal_option_stdin_err output written i


From: Mohammad Akhlaghi
Subject: [gnuastro-commits] master 0ad3717: gal_option_stdin_err output written in a literal string
Date: Tue, 27 Nov 2018 20:41:30 -0500 (EST)

branch: master
commit 0ad3717277fa7b136fda7d1629c5a17e32ad53e4
Author: Mohammad Akhlaghi <address@hidden>
Commit: Mohammad Akhlaghi <address@hidden>

    gal_option_stdin_err output written in a literal string
    
    Thanks to Raúl Infante Sainz, we noticed that Mac OS compiler issues a
    warning about the string in `error' not being a string literal when we were
    calling `gal_options_stdin_error'. With this commit, this warning will be
    supressed.
---
 bin/convertt/ui.c            | 3 ++-
 doc/announce-acknowledge.txt | 1 +
 lib/options.c                | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/bin/convertt/ui.c b/bin/convertt/ui.c
index b6ed928..ee45765 100644
--- a/bin/convertt/ui.c
+++ b/bin/convertt/ui.c
@@ -513,7 +513,8 @@ ui_make_channels_ll(struct converttparams *p)
 
   /* If there weren't any channels, abort with an error. */
   if(p->numch==0)
-    error(EXIT_FAILURE, 0, gal_options_stdin_error(p->cp.stdintimeout, 0));
+    error(EXIT_FAILURE, 0, "%s",
+          gal_options_stdin_error(p->cp.stdintimeout, 0));
 
   /* Reverse the list of channels into the input order. */
   gal_list_data_reverse(&p->chll);
diff --git a/doc/announce-acknowledge.txt b/doc/announce-acknowledge.txt
index cffd52c..0b5a011 100644
--- a/doc/announce-acknowledge.txt
+++ b/doc/announce-acknowledge.txt
@@ -3,6 +3,7 @@ Alphabetically ordered list to acknowledge in the next release.
 Fernando Buitrago
 Pierre-Alain Duc
 Gaspar Galaz
+Raúl Infante Sainz
 Johan Knapen
 Mamta Pommier
 Michael Stein
diff --git a/lib/options.c b/lib/options.c
index 7b2f3a0..5d66667 100644
--- a/lib/options.c
+++ b/lib/options.c
@@ -1396,7 +1396,7 @@ gal_options_check_stdin(char *inputname, long 
stdintimeout)
 
   /* See if atleast one of the two inputs is given. */
   if(inputname==NULL && lines==NULL)
-    error( EXIT_FAILURE, 0,  gal_options_stdin_error(stdintimeout,1));
+    error( EXIT_FAILURE, 0, "%s", gal_options_stdin_error(stdintimeout,1));
 
   /* Return the output. */
   return lines;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]