[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnuastro-commits] master b3d7775: Minor modifications for Debian releas

From: Mohammad Akhlaghi
Subject: [gnuastro-commits] master b3d7775: Minor modifications for Debian release
Date: Fri, 18 May 2018 14:13:42 -0400 (EDT)

branch: master
commit b3d7775b26ab6b0530c12e8703f58ee0bba3d556
Author: Mohammad Akhlaghi <address@hidden>
Commit: Mohammad Akhlaghi <address@hidden>

    Minor modifications for Debian release
    While packaging for Debian, I noticed that for the experimental release, we
    don't have a detached signature file. So the necessary step was added in
    the checklist. This helps in decreasing the number of Lintian warnings,
    allowing more cleaner output to focus on other more important issues.
    Also, while building in Debian, I noticed a compiler warning regarding an
    uninitialized variable in `tiff_read_separate_strip_data'. It was corrected
    by initializing to zero.
    Finally, a comment in `label_clump_significance_raw' was corrected.
 doc/release-checklist.txt | 7 +++++++
 lib/label.c               | 2 +-
 lib/tiff.c                | 4 ++--
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/doc/release-checklist.txt b/doc/release-checklist.txt
index dd926a8..8077b08 100644
--- a/doc/release-checklist.txt
+++ b/doc/release-checklist.txt
@@ -239,6 +239,13 @@ Steps necessary to Package Gnuastro for Debian.
      $ export ver=A.B.CCC
+ - [ALPHA] Build an ASCII-armored, detached signature for the tarball with
+   this command (it will make a `.asc' file by default, so use that instead
+   of `.sig' in the two following steps).
+     $ gpg -b --armor gnuastro-X.Y.ZZZZ-ZZZZ.tar.gz
  - Put a copy of the TARBALL and its SIGNATURE to be packaged in this
    directory (use a different address for the experimental releases)
diff --git a/lib/label.c b/lib/label.c
index 4408154..844cbd0 100644
--- a/lib/label.c
+++ b/lib/label.c
@@ -676,7 +676,7 @@ label_clump_significance_raw(gal_data_t *values_d, 
gal_data_t *std_d,
             /* For easy reading. */
             row = &info [ label[*a] * INFO_NCOLS ];
-            /* Get the area and flux. */
+            /* Add this pixel to this clump's area. */
             ++row[ INFO_INAREA ];
             /* In the loop `INFO_INAREA' is just the pixel counter of this
diff --git a/lib/tiff.c b/lib/tiff.c
index e9a455d..bc1467d 100644
--- a/lib/tiff.c
+++ b/lib/tiff.c
@@ -315,8 +315,8 @@ tiff_read_separate_strip_data(TIFF* tif, char *filename, 
size_t dir,
   gal_data_t *ch;
   tstrip_t strip;
   unsigned char *buf;
-  uint32_t rowsperstrip = (uint32_t)-1;
-  size_t nrow, scanline = TIFFScanlineSize(tif);
+  uint32_t rowsperstrip=(uint32_t)-1;
+  size_t nrow=0, scanline=TIFFScanlineSize(tif);
   size_t ostart=0, numch=gal_list_data_number(out);
   uint32 row, h=out->ndim==2?out->dsize[0]:out->dsize[1];

reply via email to

[Prev in Thread] Current Thread [Next in Thread]