[Gnu-arch-users] tla leaks file descriptors on ftp access

[Aldrik KLEBER]

this is a bug report from gentoo bugzilla.

I don't know if this bug was reported, so i make a citation of the report :
---------------------------------------
tla (dev-util/tla-1.2-r2) don't close data socket's file descriptor, when it
didn't find file on ftp server.
This can leed to error 227, when accessing large archive.

Problem is missing close around line 539 or 1653 in src/tla/libarch/pfs-ftp.c.

Reproducible: Always
Steps to Reproduce:
1. Build archive with over 1024 versions (or lower ulimit -n).
2. tla abrowse --merges -s -A archive--on--ftp


Actual Results:  
ftp_client_get: error getting file
/bluestar/tla/tla--scripts/tla--scripts--1.0/patch-19/log
    227: Too many open files


Expected Results:  
Finish abrowse.

[...]

Ftp server is wu-ftpd, but I don't think it can make a difference.
--------------------------------- End of citation ----------------------------