[Gnu-arch-users] Re: Can't create .listing files over FTP

[Magnus Henoch]

Magnus Henoch <address@hidden> writes:

> Robert Collins <address@hidden> writes:
>
>>> http://w1.312.comhem.se/~u31227643/archives/
>>> address@hidden/tla--ftpbug--1.3
>>> 
>>> I made pfs_ftp_rename change to the directory of the file to be
>>> renamed/moved, and change back afterwards.  This switching back and
>>> forth is suboptimal, but not knowing the code well I'm not sure which
>>> functions might depend on the current working directory.
>>> 
>>> This works for me, at least.  Not sure if it would be worth merging
>>> into tla, as it seems to be a quite rare problem.
>>
>> if you make it kick in automatically:
>> when the rename fails attempt with relative path, and remember that
>> failure, then it would make sense to me to merge.
>
> Now I've done that too.  In patch-2, it tries absolute path first,
> and falls back to relative path on failure.  In patch-3, it remembers
> such failures as the absolute_rename_bug member of
> arch_pfs_ftp_session.
>
> The latter breaks the style of arch_pfs_ftp_session, which is why I
> made sure to break the change up in two parts.  I'm not sure whether I
> like it or not; maybe there's a better way to do it.

Ping?  Can/should this be merged?

Magnus