gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [1/2]: Patch smsd/sqlite: Several bug fixes / optimizations


From: Daniele Forsi
Subject: Re: [1/2]: Patch smsd/sqlite: Several bug fixes / optimizations
Date: Sat, 23 Mar 2013 12:21:23 +0100

2013/3/23 Pedro Aguilar:

> This patch skips the sleep(1) when there was no error in WriteSMS().

I'll let Jan speak for this, but I wouldn't aplly this patch for two reasons:

the line you added has tabs instead of spaces, just use what the
surrounding lines use

the check for the error variable in while() will always be true now
since you break on the negated condition so you can use just
while (numError++ < 3);

-- 
Daniele Forsi



reply via email to

[Prev in Thread] Current Thread [Next in Thread]