Re: Add "SMS status" reporting for SMS reading (AT driver)

[Pawel Kot]

Hi,

On 7/3/07, Bastien Nocera <address@hidden> wrote:
> Here's a patch to add support for reading the status of a message with
> the AT driver. It supports both the "full text" version (used by
> Motorola phones, the G20 documentation tells me) and the "short
> numerical" version (as used by Nokias in AT mode).

Given that different models use quotes or not, I would suggest to change:
+               if (strcmp (status, "\"REC UNREAD\"") == 0) {
+                       data->raw_sms->status = GN_SMS_Unread;
+               } else if (strcmp (status, "\"REC READ\"") == 0) {
+                       data->raw_sms->status = GN_SMS_Read;
+               } else if (strcmp (status, "\"STO UNSENT\"") == 0) {
+                       data->raw_sms->status = GN_SMS_Unsent;
+               } else if (strcmp (status, "\"STO SENT\"") == 0) {
+                       data->raw_sms->status = GN_SMS_Sent;
into
+               if (strstr(status, "UNREAD")) {
+                       data->raw_sms->status = GN_SMS_Unread;
+               } else if (strstr(status, "READ")) {
+                       data->raw_sms->status = GN_SMS_Read;
+               } else if (strstr(status, "UNSENT")) {
+                       data->raw_sms->status = GN_SMS_Unsent;
+               } else if (strstr(status, "SENT")) {
+                       data->raw_sms->status = GN_SMS_Sent;

And is it case sensitive?

> I didn't manage to test it properly on my Nokia in AT mode, as it lies
> about the number of SMSes in its different folders.

Well, Nokia AT mode doesn't support folders. :)

> I'm trying to fix:
> http://bugzilla.gnome.org/show_bug.cgi?id=330773

But the patch is for the quite different thing...

> and I noticed that only some Nokia drivers implemented GN_OP_OnSMS or
> GN_OP_PollSMS. Would it be interesting to have CNMI support in the
> generic AT driver?

Sure!

> PS: current gnokii CVS HEAD crashes for me when using the AT driver,
> straight after an ATZ. Anyone seeing that?

Nope. Just tested over rfcomm. Any details?

take care,
pkot
--
Pawel Kot