[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: smsd: reconnect only on timeout

From: Pawel Kot
Subject: Re: smsd: reconnect only on timeout
Date: Fri, 17 Nov 2006 20:59:16 +0100


On 11/17/06, Jan Derfinak <address@hidden> wrote:
On Fri, 17 Nov 2006, Pawel Kot wrote:


> What do you think about the following change in smsd: reconnect only
> in case of timeout, not any error.

Idea is OK, but I don't like goto construction. I rewrited patch without
goto. It also contains fix for warning on line 98:
"warning: assignment discards qualifiers from pointer target type"

Well, it's that matter of taste: whether nested if is nicer than goto.
But anyway it's fine for me.

Pawel Kot

reply via email to

[Prev in Thread] Current Thread [Next in Thread]