gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: at-emulator.c has ASCII values of CR and LF swapped


From: Pawel Kot
Subject: Re: at-emulator.c has ASCII values of CR and LF swapped
Date: Tue, 21 Jun 2005 00:01:59 +0200

Hi Daniele,

On 6/20/05, Daniele Forsi <address@hidden> wrote:
> I found that ASCII values for CR and LF are swapped.
> The enclosed patch changes this and all strings to have a trailing \r\n,
> except a couple of error strings and a couple of other strings which do need
> it at the beginning.
> 
> With this patch gnokiid starts to be compatible with gnokii configured with
> port = /dev/gnokii and model = AT :-) so that gnokii --identify at least
> prints something useful (I'm going to submit another patch for this and other
> things in the next days)

Looks good, but...

> Index: common/data/at-emulator.c
> ===================================================================
> RCS file: /cvsroot/gnokii/gnokii/common/data/at-emulator.c,v
> retrieving revision 1.42
> diff -r1.42 at-emulator.c
> 180,181c180,181
> <       ModemRegisters[REG_CR] = 10;
> <       ModemRegisters[REG_LF] = 13;

... diff -u please.

take care,
pkot
-- 
Pawel Kot
http://www.gnokii.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]