Re: Gnokii patch - pls review

[BORBELY Zoltan]

Hi,

On Fri, Jul 16, 2004 at 09:34:49PM +0200, Marco Canini wrote:
> I'm attaching a patch for gnokii.c that solves a problem I had while using 
> gnokii to get the phonebook of my nokia 7110.
> The problem was present when running gnokii --get-phonebook ME 1 end.
> Whit that cmd line gnokii was getting all the phonebook but after getting all 
> phonebook entries it was reading also empty slots and was timing out.
> The attached patch solves the problem in this way:
> 1) first it reads how many entries are present in the phonebook
> 2) then it reads a number of entries equal to the value obtained in 1
> Any coments?
> Fell free to commit if you think it's right

There was a little problem with your patch: the phonebook can be sparse
(there can be gaps between 1 .. num_of_used_entries). I committed a
modified patch into the cvs.

Thanks,
Bozo