Re: [FWD] gnokii patch (for 6310)

[BORBELY Zoltan]

Hi,

On Thu, Mar 13, 2003 at 04:27:18PM +0100, Markus Plail wrote:
> X-From-Line: address@hidden Thu Mar 13 14:33:38 2003
> Delivered-To: address@hidden
> Subject: gnokii patch (for 6310)
> To: address@hidden
> Date: Thu, 13 Mar 2003 06:27:30 -0800 (PST)
> Reply-To: address@hidden (Troy K.), <address@hidden>
> From: "Troy" <address@hidden>
> X-Info: None
> X-Spam-Status: No, hits=-5.2 required=5.0
>       tests=MIME_MISSING_BOUNDARY,PATCH_UNIFIED_DIFF
>       autolearn=ham   version=2.50-cvs
> X-Spam-Level: 
> X-Spam-Checker-Version: SpamAssassin 2.50-cvs (1.172-2003-02-14-exp)
> Xref: localhost.localdomain Markus:1898
> 
> Markus,
> 
> I needed to do a few fixes to get rid of some complaints
> with gnokii-0.5.0rc1.
> 
> My environment is 
> gcc (GCC) 3.2 and linux kernel 2.4.18.
> Nokia 6310
> 
> I am attaching a patch. 
> 
> Here is a description of the issues:
> 
> 1.
> include/config.h.in:
> xgnokii.c:
> The patch adds "_GNU_SOURCE" to include/config.h.in, so 
> asprintf is found. (misc.h includes stdio.h which checks for
> _GNU_SOURCE.) The _GNU_SOURCE definition in xgnokii.c never gets
> included because stdio.h has already been read by the time
> we get there. I added the definition to config.h in case
> some other function in the future might also need the def.

I haven't applied it yet. Defining the _GNU_SOURCE can cause portability
problems. I want to do some test first.

> 2. 
> data.h: 
> Change send_message function to take a u16 instead of unsigned int. That's
> how it's used.

Fixed it from the opposite direction. I modified the link layer functions
to use unsigned int instead of u16. Pawel wants to eliminate the u8/u16/u32
from the exported functions.

> 3.
> mgnokiidev.c:
> Add an include for <string.h>, required by strdup.

Applied.

Thanks for the patches.

Bye,
Bozo