gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Some minor fixes for gnokii


From: Jan de Cuveland
Subject: Some minor fixes for gnokii
Date: Sat, 26 Oct 2002 18:58:48 +0200
User-agent: Mutt/1.3.22.1i

Hi,

I was trying to write my phonebook into my 6510 using the current CVS
version of gnokii and ran into some problems.

Now with some minor fixes everything runs fine for me. So I would like to
ask the developers to consider adding my patches to the CVS.

What do the patches do?
* The first corrects an obvious mistake (?) in gnooki.c.
* The second increases the size of a struct. This is necessary because
  otherwise gnokii segfaults with some large entries. (There is no range
  checking, so gnokii overwrites the return address -> bad!)
* The third is a patch to /common/gsm-encoding.c. The problem is, that
  mbtowc and wctomb do not work as desired with the special characters of
  a latin1 charset. Returning -1 is anyway a bad idea, since it
  effectively deletes the previous character of the string as well.
  Since I only changed the behaviour in case of error, I think these
  modifications will not break anything.

Regards,
Jan


Attachment: cvs-diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]