gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Problems with newest smsd


From: Markus Plail
Subject: Re: Problems with newest smsd
Date: Tue, 06 Aug 2002 15:57:46 +0200
User-agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.3.50 (i686-pc-linux-gnu)

Hi Markus.. erm.. replying to yourself is stupid ;-)

* Markus Plail writes:
> Hi Pawel!
* Pawel Kot writes:
>>> I think it's because:
>>> data-> SMSFolder = NULL;
>>> in nk7110.c:P7110_GetSMSNoValidate(). Not sure though, why we do this 
>>> assignment.
>> OK. I know. It's because we don't want to validate SMS inside IncomingSMS()
> But:
> 1. We don't call GetSMSNoVValidate in smsd
> 2. I am quite sure that SMSFolderList was the reason, because SMSFolder
>    was checked for being NOT NULL in ValidateSMS()

OK now I see... GetSMS calls GetSMSnoValidate. and we shouldn't set
data->SMSFolder = NULL there. This assignment was doubled btw. Before
data->it should only have been above in the case GOP_GetSMSNoValidate
data->block, but after my latest changes concerning unread messages in
data->6210 series this isn't needed anymore.
I will commit the fix soon.

regards
Markus




reply via email to

[Prev in Thread] Current Thread [Next in Thread]