Re: Problems with newest smsd

[Markus Plail]

Hi Michael!

* Michael Meier writes:
>> What happens when you do 'gnokii --getsms IN 1 3'? Does it 
>> segfault, too? 

> Nope, it shows first 3 messages in inbox and exits correctly, while the
> third is part 3 of a linked message (part 2 and 1 are in fourth and
> fifth slot).


Ok. I realized what the problem is. Actually there are two: 
1. phone driver shouldn't segfault but exit with appropriate error code
2. Jano changed my patch a bit, which lead to the segfault, but it
   would still not work without the error in the phone driver.

I realize that this change isn't obvious at all, and that actually
there is no real reason for it, not to work Jano's way, but only
mine. Still I think that, especially when one can't test the code, it
should have been better to ask me why I did this. Especially as it was
clear that this code will go relatively untested (from others than the
author) into the next release. All IMHO and considering that I am in a
real bad mood today.

regards
Markus

PS: Fix for the segfault will appear in CVS soon.

Index: smsd/lowlevel.c
===================================================================
RCS file: /cvsroot/gnokii/gnokii/smsd/lowlevel.c,v
retrieving revision 1.19
diff -u -r1.19 lowlevel.c
--- smsd/lowlevel.c     5 Aug 2002 08:10:54 -0000       1.19
+++ smsd/lowlevel.c     6 Aug 2002 12:09:47 -0000
@@ -242,9 +242,7 @@
   pthread_mutex_unlock (&smsMutex);
 
   GSM_DataClear(&data);
-  data.SMSFolderList = &folderlist;
   folder.FolderID = 0;
-  data.SMSFolder = &folder;
   
   i = 0;
   while (1)
@@ -257,6 +255,8 @@
       msg->MemoryType = GMT_SM;
     msg->Number = ++i;
     data.SMS = msg;
+    data.SMSFolderList = &folderlist;
+    data.SMSFolder = &folder;
     
     if ((error = GetSMS (&data, &sm)) == GE_NONE)
     {