[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch 3

From: BORBELY Zoltan
Subject: Re: Patch 3
Date: Wed, 3 Apr 2002 12:58:29 +0200
User-agent: Mutt/


On Wed, Apr 03, 2002 at 11:07:31AM +0200, Pawel Kot wrote:
> And I'd like to point one important thing. We use identify function too much.
> Two examples. The first example: when you do gnokii --identify identify()
> function is called twice. The second example: running gnokii identify() is
> called every time some functionality is used. We need to get rid of it and
> use identify() only *once* for the user application run. We need to check
> some global values (representing model etc) in identify(). Anyone to do it?
> Thanks to Igor Popik for pointing me it out and saying that it's dumb ;-)

Yes, I know about it. But I don't want to introduce another global variables
in the phone drivers. It won't help the multiple phone support in the future
:-)  The better solution is to extend the GSM_Statemachine (or GSM_Phone -
it isn't important) to include phone _instance_ and model specific data.
We can store this info there. But the major problem is that the incoming
functions cannot get the state structure. We should modify _all_ of the
incoming function to get GSM_Statemachine *state as an argument.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]