gnokii-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-48


From: Daniele Forsi
Subject: [SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-484-g32d4e07
Date: Wed, 24 Apr 2013 13:10:38 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".

The branch, master has been updated
       via  32d4e07b0c0d86df4646b6d5393bfcb7816ac194 (commit)
      from  b7ebb632d74442ce790f666febb635a5325d47ca (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/gnokii.git/commit/?id=32d4e07b0c0d86df4646b6d5393bfcb7816ac194


commit 32d4e07b0c0d86df4646b6d5393bfcb7816ac194
Author: Daniele Forsi <address@hidden>
Date:   Wed Apr 24 14:38:54 2013 +0200

    Fix possible NULL dereference
    
    Do not call closedir() when argument is NULL, ie when 
/usr/share/xgnokii/xpm/
    doesn't exist. The "dir" variable isn't modified in the loop so it can be
    checked before entering it.
    
    Fixes the following error from scan-build:
    Null pointer passed as an argument to a 'nonnull' parameter

diff --git a/xgnokii/xgnokii_logos.c b/xgnokii/xgnokii_logos.c
index c0e94c6..299381d 100644
--- a/xgnokii/xgnokii_logos.c
+++ b/xgnokii/xgnokii_logos.c
@@ -145,7 +145,9 @@ static void GetPixmaps(gchar *path)
        struct dirent *de;
 
        dir = opendir(path);
-       while (dir && (de = readdir(dir))) {
+       if (dir == NULL)
+               return;
+       while ((de = readdir(dir))) {
                if (pixmapFiles == MAX_PIXMAPS)
                        break;
                if (!strncmp(de->d_name, "Preview_", 8)) {

-----------------------------------------------------------------------

Summary of changes:
 xgnokii/xgnokii_logos.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
libgnokii and core programs



reply via email to

[Prev in Thread] Current Thread [Next in Thread]