[SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-24-gda69378

[Daniele Forsi]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".

The branch, master has been updated
       via  da69378debdbf020ad51c99c1acf419a2f0a988b (commit)
      from  f0e699677c616bfff729d260a713e4384a17506a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/gnokii.git/commit/?id=da69378debdbf020ad51c99c1acf419a2f0a988b


commit da69378debdbf020ad51c99c1acf419a2f0a988b
Author: Daniele Forsi <address@hidden>
Date:   Sun Jun 20 10:59:02 2010 +0200

    Drop "T" modifier from ATDT for compatibility and flexibility
    
    Not all phones ignore it (eg. Sony Ericsson Z310i chokes on it) even if GSM
    07.07 says its implementation is mandatory but it is ignored; also it
    prevents the use of direct dialling from phonebooks because it conflicts
    with the ">" modifier.
    At this time the "ATD><str>" variant works only if encoding of <str> matches
    what the phone expects, no conversion is done by libgnokii.

diff --git a/ChangeLog b/ChangeLog
index f81d859..d9d62ce 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -17,6 +17,10 @@
  * fake driver updates
     o implement enough GN_OP_GetSMSStatus and GN_OP_DeleteSMS to
       test smsd receiving with static and file SMS  (Daniele Forsi)
+ * at driver updates
+    o drop "T" modifier from ATDT because not all phones ignore it
+      and it prevents the use of direct dialling from phonebooks;
+      see gnokii man page and GSM 07.07             (Daniele Forsi)
 
 0.6.29
 ======
diff --git a/Docs/man/gnokii.1 b/Docs/man/gnokii.1
index 83b691f..f6ade7f 100644
--- a/Docs/man/gnokii.1
+++ b/Docs/man/gnokii.1
@@ -1,4 +1,4 @@
-.TH "gnokii" "1" "Sep 29, 2008" "Dag Wieers, Pawel Kot" "gnokii"
+.TH "gnokii" "1" "Jun 20, 2010" "Dag Wieers, Pawel Kot" "gnokii"
 .SH "NAME"
 gnokii \- modem/fax driver for the mobile phones
 .SH "SYNOPSIS"
@@ -80,6 +80,11 @@ specify speed dial.
 initiate voice call.
 On success print the \fIcallid\fP identifier to be used with the \-\-hangup 
command.
 The \-\-monitor command can be used to show the \fIcallid\fP.
+
+With \fImodel = AT\fP direct dialing from phonebooks is supported with careful 
use
+of shell escaping, for example:
+ gnokii \-\-dialvoice ">SM42"   # dial the number in location 42 of SM memory
+ gnokii \-\-dialvoice '>"Home"' # dial the number if string matches exactly a 
contact name
 .TP 
 .BR "\-\-senddtmf \fIstring\fP"
 send DTMF sequence.
diff --git a/common/phones/atgen.c b/common/phones/atgen.c
index f109099..f49804c 100644
--- a/common/phones/atgen.c
+++ b/common/phones/atgen.c
@@ -1559,7 +1559,7 @@ static gn_error AT_DialVoice(gn_data *data, struct 
gn_statemachine *state)
 
        if (!data->call_info)
                return GN_ERR_INTERNALERROR;
-       snprintf(req, sizeof(req), "ATDT%s;\r", data->call_info->number);
+       snprintf(req, sizeof(req), "ATD%s;\r", data->call_info->number);
        if (sm_message_send(strlen(req), GN_OP_MakeCall, req, state))
                return GN_ERR_NOTREADY;
        return sm_block_no_retry(GN_OP_MakeCall, data, state);

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog             |    4 ++++
 Docs/man/gnokii.1     |    7 ++++++-
 common/phones/atgen.c |    2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
libgnokii and core programs