[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnewsense-dev] Debderive

From: Sam Geeraerts
Subject: Re: [Gnewsense-dev] Debderive
Date: Sat, 03 Mar 2012 14:15:06 +0100
User-agent: Thunderbird (X11/20101029)

Stayvoid wrote:
This one fixes several things:

Please re-submit this with separate issues in separate patches. It's frustrating to look back on a commit diff later and having to weed out the change that caused a bug. It's also a lot quicker to read a patch that fixes one issue throughout the code than having to think with every changed line what it's fixing exactly.

1) the length of the lines (72 for the comments and 79 for the rest).

Good catch, I didn't take 72 for comments into account. I'll have to find out how to configure Vim for that.

> (Should it count spaces?);


2) removes spaces from the end of the lines. (Does it really matter?);

No, but I'll accept a patch for it.

3) replaces print >> sys.stderr with sys.stderr.write().

I'm not sure that I did it right for the docs and comments.
What style is the best?

According to the typographic tradition, an article shouldn't stay
without a noun at the end of the line.
But maybe it's OK for the code.

It is. I wouldn't worry about that.

Is there a guide for this?

Not that I'm aware of.

Maybe we should get rid of backslashes. What do you think?
"Long lines can be broken over multiple lines by wrapping expressions
in parentheses.
These should be used in preference to using a backslash for line
continuation." [a]

We should, but be sure to test, because you can't always just remove the backslash.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]