Re: [Gnash] Patch: Give error for unhandled SWF events

[strk]

I dont' know much of the code as well, so I'm completely
trusting you on this patch. 
Now that Rob is back he might take a closer look at this.

--strk;

On Wed, Jan 18, 2006 at 11:39:01PM +0800, Michael Carlson wrote:
> Regarding the "is it safe to make assumptions about what's known and
> handled in swf_event::read()", I'm trying not to change anything about
> the flow of the program. The patch really doesn't "fix" anything, it
> just gives more information: it reports the hex of the unidentified
> event flag it sees so it's easier (for a developer) to see what's
> going on for flash files that don't work. I just want to make a clear
> error message telling the event that was received isn't known by the
> array - in this situation, it looks like m_event will not change from
> the last call, and the previous event received will be repeated,
> instead of the intended event. This should probably be fixed, but I
> don't know the code well enough (yet) to decide on an appropriate
> solution - thus the error message.
> 
> I'm not sure I know what you mean when you say it's "better to add the
> debugging". Do you mean there is a macro, or something else in gnash's
> code base I should be using instead of this? I welcome suggestions for
> improvement of the patch, but it's hardly an important one. I'm just
> dipping my toe in the patch-contribution-waters, so to speak.
> 
> Sincerely,
> Mike
> 
> On 1/18/06, strk <address@hidden> wrote:
> > Oh, btw, I keep getting this :
> >  Fatal signal: Segmentation Fault (SDL Parachute Deployed)
> > When opening google-video.swf both *with* and *without*
> > your patch (with CVS version).
> >
> > --strk;
> >
> > On Wed, Jan 18, 2006 at 10:10:36AM +0100, strk wrote:
> > > Committed, but I'm not sure about it being the right thing.
> > > I mean, is it safe to make assumptions about what's
> > > known and handled in swf_event::read() ?
> > > Or should the logging happen when the Assert fails instead ?
> > > --strk;
> > >
> > > it be better to add the debugging
> > >
> > > On Sun, Jan 15, 2006 at 01:47:29AM +0800, Michael Carlson wrote:
> > > > Download this file : http://protu.it.helsinki.fi/~lindi/google-video.swf
> > > >
> > > > Then, try opening it locally with gnash, using the "-va" command switch 
> > > > (for
> > > > verbose Movie Actions). The program will crash with an assertion error.
> > > > After some investigating, I realized that in server/impl.cpp,
> > > > swf_event::read(), we don't do any sort of check to see if the event 
> > > > flag
> > > > that was sent to us is known and handled by the program. This patch 
> > > > simply
> > > > adds a log_error statement, letting you know that an event was received 
> > > > that
> > > > is unknown and unhandled, the hex code of the event, as well as an
> > > > appropriate comment in the source explaining this check.
> > > >
> > > > This is my first patch to gnash, and it's very small. I plan to 
> > > > contribute
> > > > more. If there is any problem with the formatting / method of 
> > > > submission,
> > > > please tell me the best way for next time.
> > > >
> > > > Sincerely,
> > > > Michael Carlson
> > >
> > >
> > > > _______________________________________________
> > > > Gnash mailing list
> > > > address@hidden
> > > > http://lists.gnu.org/mailman/listinfo/gnash
> >
> > --
> >
> >  /"\    ASCII Ribbon Campaign
> >  \ /    Respect for low technology.
> >   X     Keep e-mail messages readable by any computer system.
> >  / \    Keep it ASCII.
> >
> >

-- 

 /"\    ASCII Ribbon Campaign
 \ /    Respect for low technology.
  X     Keep e-mail messages readable by any computer system.
 / \    Keep it ASCII.