Re: [Gnash-dev] async plugin installation

[Dag Hovland]

Den 31. mai 2016 14:20, skrev Sandro Santilli:
> On Tue, May 31, 2016 at 01:43:37PM +0200, Dag Hovland wrote:
> > Den 31. mai 2016 10:26, skrev Sandro Santilli:
> > > On Tue, May 31, 2016 at 10:17:58AM +0200, Dag Hovland wrote:
> > > > Den 30. mai 2016 15:43, skrev Sandro Santilli:
> > > > > There's a Gui::yesno() method, if that's enough (triggered when
> > > > > a script takes too much time). Or you could add another interface
> > > > > to Gui for something more sophisticated.
> > > > That looks nice. Is there a way to get the gui object?
> > > You communicate with GUI via HostInterface, usually calling:
> > >
> > >   movie_root::callInterface(const HostInterface::Message& e) const
> > >
> > > See libcore/HostInterface.h
> > Ok, thanks. But how do you get the movie_root object? I tried
> > passing it down in the calls from gnash.cpp but that means adding
> > movie_root to a lot of classes. Is there a factory or some static
> > class where you can get at it?
> You hadn't mentioned yet where you are starting from, anyway
> any as_object can give you the root via getRoot().
>
> Use `git grep getRoot` to get a feel of it

Thanks for your time and answers.

This is in libmedia/gst/GstUtil.cpp::check_missing_plugins(GstCaps* 
caps), a static method. The only available object is of the class 
GstCaps from GStreamer. In the attached patch I tried out passing the 
movie_root object down from the originating as_objects into GstUtil. It 
feels a bit ugly to add it to all these function calls, perhaps some 
static method or factory would be better, but not sure where that would 
fit best.

I added dialogs for the different return situations of the plugin installer.
I prevented repeated occurrences of plugin installation in case the user 
once has clicked Cancel. (Otherwise the plugin installer pops up again 
and again and again if there is some external reason it cannot be 
installed.)

Dag
> --strk;
>
>    ()   Free GIS & Flash consultant/developer
>    /\https://strk.kbt.io/services.html

plugin_installer.patch
Description: Text Data