[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-dev] [PATCH] Make mouse events more responsive
From: |
strk |
Subject: |
Re: [Gnash-dev] [PATCH] Make mouse events more responsive |
Date: |
Tue, 25 Jul 2006 15:20:36 +0200 |
Ivor, thanks for your patch. It looks fine to me but I'd ask
Bastiaan if he can commit it as he's more in the Gui biz :)
I've fixed the libgnashasobj.la bug for klash, please try
again.
--strk;
On Tue, Jul 25, 2006 at 10:54:22PM +1000, Ivor Blockley wrote:
> Hi all,
>
> Attached is a patch that fixes a bug with mouse-event handling.
>
> The problem:
> Rapid mouse clicking may result in some clicks not being honoured.
>
> To demonstrate load
> gnash/testsuite/actionscript.all/visible_and_transparency.swf and then rapidly
> click one of the "Lower Alpha" buttons or rapidly hide and show the Primary
> window via the "Hide
> Primary" and "Show Primary" buttons. A double-clicking speed or faster is
> required for repeatable
> results.
>
> The patch:
> This patch resolves the problem by moving some of the mouse-event
> generation/handling code outside
> the "movie" loop. It has been tested as working under GTK and SDL and should
> apply cleanly against
> CVS.
>
> Caveats:
> * Is this solution thread-safe?
>
> * I'm having problems building Klash and thus the patch has not been tested
> under KDE (although I
> believe it should work). I get the following error when I try to make Klash
> (on an AMD64 Ubuntu
> 6.06[Dapper] system):
> make[3]: *** No rule to make target `../../server/libgnashasobjs.la', needed
> by `klash'. Stop.
>
> I am working on another patch to resolve
> https://savannah.gnu.org/bugs/?func=detailitem&item_id=16969 which will
> require testing with
> Klash. (PS: bug 16969 has been marked "Ready For Test" but the bug still
> exists in CVS, as can be
> demonstrated by re-sizing the GTK window for visible_and_transparency.swf and
> then clicking on
> some buttons).
>
> The patch itself: