Re: [Gnash-commit] /srv/bzr/gnash/trunk r12341: Refactored input device support for the framebuffer GUI.

[Benjamin Wolsey]

When I try to build Gnash with all GUIs now I get the following errors
and warnings. This was after autogen.sh and configure:

/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp: In destructor
'virtual gnash::TouchDevice::~TouchDevice()':
/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp:66: error:
'ts_close' was not declared in this scope
/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp: In member
function 'virtual bool gnash::TouchDevice::init(const std::string&,
size_t)':
/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp:95: error:
'ts_open' was not declared in this scope
/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp:101: error:
'ts_config' was not declared in this scope
/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp:102: error:
'ts_fd' was not declared in this scope
/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp: In member
function 'virtual bool gnash::TouchDevice::check()':
/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp:118: error:
aggregate 'gnash::ts_sample event' has incomplete type and cannot be
defined
/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp:126: error:
'ts_read' was not declared in this scope
/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp: In static
member function 'static
std::vector<boost::shared_ptr<gnash::InputDevice>,
std::allocator<boost::shared_ptr<gnash::InputDevice> > >
gnash::TouchDevice::scanForDevices(gnash::Gui*)':
/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp:290: warning:
missing braces around initializer for
'gnash::TouchDevice::scanForDevices(gnash::Gui*)::ts_types'
/home/benjamin/Downloads/gnash/trunk/gui/TouchDevice.cpp:290: warning:
missing braces around initializer for
'gnash::TouchDevice::scanForDevices(gnash::Gui*)::ts_types'

It seems TouchDevice and InputDevice are built not only for FB, but also
for all the other GUIs, which seems wrong (not to mention adding to the
build time!).

If the FB GUI is disabled, the other GUIs build fine without the extra
code building.

There are also many warnings that point to bugs in the code, and fixing
the warnings would be easier than waiting for bug reports!

bwy

--
The current release of Gnash is 0.8.7
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de
C++ and Open-Source Flash blog - http://www.benjaminwolsey.de/bwysblog

xmpp:address@hidden
http://identi.ca/bwy

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil