Re: [Gnash-commit] /srv/bzr/gnash/trunk r12149: move the callbacks to a separate file.

[Bastiaan Jacques]

+            NPVARIANT_IS_NULL(*result);

This is a boolean expression and so I think it has no effect.
Presumably the idea is to do something like 
NULL_TO_NPVARIANT(*result).

SetVariableCallback:
...
    if (argCount == 2) {
        varname = NPVARIANT_TO_STRING(args[0]).UTF8Characters;

Is there some requirement that args[0] is a string NPVariant?
If so, that should probably be asserted. Otherwise, the type
should be checked before bad things happen.

IsPlaying:

NPN_MemFree(reinterpret_cast<void *>(value));

This cast is not needed, right?

I get the impression that NPVariant is intended to be used on the stack.
That might simplify things. The idea is then to call
  NPN_ReleaseVariantValue(&stack_npvar);
To release memory associated with a string or object contained within.

Bastiaan

On Wed, 14 Apr 2010, Rob Savoye wrote:

> ------------------------------------------------------------
> revno: 12149
> committer: Rob Savoye <address@hidden>
> branch nick: trunk
> timestamp: Wed 2010-04-14 13:48:12 -0600
> message:
>  move the callbacks to a separate file.
> added:
>  plugin/npapi/callbacks.cpp
>  plugin/npapi/callbacks.h
> modified:
>  plugin/npapi/Makefile.am
>  plugin/npapi/pluginScriptObject.cpp