On Thu, Aug 13, 2009 at 12:27 AM, Benjamin Wolsey
<address@hidden> wrote:
Since Savannah appears not to be sending commit emails, here's another
DIY diff.
+// Things to work on:
+// - Cannot figure out how to open firefox in different ways--this
+// is what target is supposed to do
And not just firefox... This should be easy to fix. You need a reference
to the movie_root using getRoot() on an object or fn_call. Then simply
call movie_root::getURL with the URL and target (see function for
usage). This will handle both plugin and non-plugin situations, and
means you don't have to do any of the browser invocation yourself:
+ std::string target = rec.getTarget();
+
+ for (size_t i=0; i < target.size(); ++i) {
+ target[i] = toupper(target[i]);
+ }
+
+ if ( target[0] == '_' ) {
+ target.erase(0);
+ }
This case conversion and editing is then probably unnecessary, as the
hosting application (usually the browser) should be able to handle case
difference.
movie_root& m = getRoot(*this);
if (!rec.getURL().empty() {
m.getURL(rec.getURL(), rec.getTarget());
}
Would (I hope) handle all cases.
bwy
--
The current release of Gnash is 0.8.5
http://www.gnu.org/software/gnash/
Benjamin Wolsey, Software Developer - http://benjaminwolsey.de
_______________________________________________
Gnash-commit mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/gnash-commit